Remove unnecessary path-is-absolute dependency#1062
Merged
kibertoad merged 1 commit intoforeversd:masterfrom Feb 18, 2020
MasterOdin:pathIsAbsolute
Merged
Remove unnecessary path-is-absolute dependency#1062kibertoad merged 1 commit intoforeversd:masterfrom MasterOdin:pathIsAbsolute
kibertoad merged 1 commit intoforeversd:masterfrom
MasterOdin:pathIsAbsolute
Conversation
Contributor
|
Trying to trigger build... |
kibertoad
approved these changes
Feb 18, 2020
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
path-is-absolute is a polyfill for NodeJS <0.12 which did not have path.isAbsolute. Given that forever requires an engine that fits
node >= 6, I figure it is probably safe to remove this package, and fix at least one of the deprecation warnings someone might get when installing forever. May still see the warning as forever-monitor useschokidar@2which uses it, need to move tochokidar@3to solve that, which would require moving tonode >= 8.