Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds two performance optimizations to BigDecimal's exponential functions: rational root decomposition for fractional roots and a hybrid Taylor/atanh approach for the natural logarithm series.
Changes:
- Added rational root decomposition for
root()to compute fractional roots like x^(2/3) usinginteger_power(integer_root(x, a), b)instead of the expensiveexp(ln(x)/n)path - Refactored
ln_series_expansion()to use atanh identity for large z values, reducing iterations by ~3× through faster convergence (rate 1/9 vs 1/2) - Fixed markdown table-of-contents comment syntax from "omit in toc" to "omit from toc"
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/decimojo/bigdecimal/exponential.mojo | Added _gcd() helper, _rational_root_decomposition() function, integrated rational root decomposition into root(), and refactored ln_series_expansion() with hybrid Taylor/atanh approach |
| docs/readme_zht.md | Fixed markdown TOC comment syntax (spelling fix) |
| docs/readme_unreleased.md | Fixed markdown TOC comment syntax (spelling fix) |
| docs/readme_tomlmojo.md | Fixed markdown TOC comment syntax (spelling fix) |
| docs/plans/bigdecimal_biguint_benchmark_analysis.md | Updated task completion status for Task 3f (atanh for ln) and Task 7c (rational root decomposition) |
| README.md | Fixed markdown TOC comment syntax (spelling fix) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two performance optimizations to BigDecimal's exponential functions: rational root decomposition for fractional roots and a hybrid Taylor/atanh approach for the natural logarithm series.
Changes:
root()to compute fractional roots like x^(2/3) usinginteger_power(integer_root(x, a), b)instead of the expensiveexp(ln(x)/n)pathln_series_expansion()to use atanh identity for large z values, reducing iterations by ~3× through faster convergence (rate 1/9 vs 1/2)