Conversation
forfudan
changed the title
There was a problem hiding this comment.
Pull request overview
This PR initializes a CLI calculator application for the Decimo library, implementing a complete expression evaluator with tokenization, parsing (shunting-yard algorithm), and evaluation using BigDecimal arithmetic. The implementation supports basic arithmetic operations (+, -, *, /), parentheses, and unary negation with arbitrary precision.
Changes:
- Added CLI calculator engine with tokenizer, parser, and evaluator modules
- Implemented comprehensive test suites for each component (tokenizer, parser, evaluator)
- Added CLI entry point with ArgMojo for command-line argument parsing
- Updated project documentation and build configuration
Reviewed changes
Copilot reviewed 13 out of 15 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/cli/main.mojo | CLI entry point using ArgMojo for parsing command-line arguments |
| src/cli/calculator/tokenizer.mojo | Lexical analyzer converting expression strings to tokens |
| src/cli/calculator/parser.mojo | Shunting-yard algorithm converting infix to RPN notation |
| src/cli/calculator/evaluator.mojo | RPN evaluator using BigDecimal for arithmetic operations |
| src/cli/calculator/init.mojo | Package initialization exporting public API |
| tests/cli/test_tokenizer.mojo | Comprehensive tokenizer test suite |
| tests/cli/test_parser.mojo | Parser test suite validating precedence and associativity |
| tests/cli/test_evaluator.mojo | End-to-end evaluator tests |
| tests/test_cli.sh | Shell script to run CLI tests |
| tests/test_all.sh | Updated to include CLI tests |
| pixi.toml | Added CLI build tasks and Python dependency |
| pixi.lock | Updated dependency lockfile |
| docs/readme_unreleased.md | Added project structure section and CLI documentation |
| docs/plans/cli_calculator.md | Added Phase 5 future enhancements |
| .gitignore | Added CLI binary to ignore list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+93
to
+99
| # Yuhao Zhu: | ||
| # I am seriously thinking that whether I should also support recoginizing | ||
| # full-width digits and operators, so that users can copy-paste expressions from | ||
| # other sources without having to manually convert them. This would be a nice | ||
| # feature for Chinese-Japanese-Korean (CJK) users. | ||
| # But it would also add some complexity to the tokenizer, because these | ||
| # full-width characters have different byte numbers. |
There was a problem hiding this comment.
Corrected spelling of 'recoginizing' to 'recognizing'.
Comment on lines
+13
to
+14
| mojo = "==0.26.1" | ||
| python = ">=3.13,<3.14" |
There was a problem hiding this comment.
The mojo and python dependencies are not in alphabetical order. Consider placing them alphabetically (mojo before python) for consistency with the argmojo entry above.
| | v0.6.0 | ==0.25.7 | pixi | | ||
| | v0.7.0 | ==0.26.1 | pixi | | ||
| | v0.8.0 | ==0.26.1 | pixi | | ||
| | libary | version | Mojo version | package manager | |
There was a problem hiding this comment.
Corrected spelling of 'libary' to 'library'.
Suggested change
| | libary | version | Mojo version | package manager | | |
| | library | version | Mojo version | package manager | |
forfudan
added a commit
that referenced
this pull request
Mar 23, 2026
…ser (#170) This PR initializes a CLI calculator application for the Decimo library, implementing a complete expression evaluator with tokenization, parsing (shunting-yard algorithm), and evaluation using BigDecimal arithmetic. The implementation supports basic arithmetic operations (+, -, *, /), parentheses, and unary negation with arbitrary precision. **Changes:** - Added CLI calculator engine with tokenizer, parser, and evaluator modules - Implemented comprehensive test suites for each component (tokenizer, parser, evaluator) - Added CLI entry point with ArgMojo for command-line argument parsing - Updated project documentation and build configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR initializes a CLI calculator application for the Decimo library, implementing a complete expression evaluator with tokenization, parsing (shunting-yard algorithm), and evaluation using BigDecimal arithmetic. The implementation supports basic arithmetic operations (+, -, *, /), parentheses, and unary negation with arbitrary precision.
Changes: