Conversation
There was a problem hiding this comment.
Pull request overview
Updates the CLI calculator to use ArgMojo v0.5.0 and migrates the argument parsing code to ArgMojo’s declarative Parsable API.
Changes:
- Replaced imperative
Command/Argsetup with aDecimoArgs(Parsable)definition and parsing viato_command()/parse_from_command(). - Switched the project to depend on
argmojo >=0.5.0,<0.6.0and simplified CLI build steps to rely on the packaged dependency. - Removed the CI “fetch argmojo” step now that ArgMojo is pulled in via pixi.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/cli/main.mojo |
Migrates CLI arg parsing to ArgMojo’s declarative Parsable model and adds help tips. |
pixi.toml |
Adds ArgMojo v0.5 dependency and updates tasks/build steps to stop using a local clone by default. |
pixi.lock |
Locks ArgMojo v0.5.0 for supported platforms. |
.github/workflows/run_tests.yaml |
Removes the step that cloned ArgMojo in CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the CLI calculator to use ArgMojo v0.5.0 and migrates the argument parsing code to ArgMojo’s declarative
ParsableAPI (hybrid, with builder API).Changes:
Command/Argsetup with aDecimoArgs(Parsable)definition and parsing viato_command()/parse_from_command().argmojo >=0.5.0,<0.6.0and simplified CLI build steps to rely on the packaged dependency.