Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands the CLI’s documentation and validation tooling by adding an end-to-end benchmark suite (vs bc and python3) and improving CLI file-mode test coverage using checked-in fixture files.
Changes:
- Add
benches/cli/bench_cli.shand wire it intopixi run bench cli. - Expand
tests/test_cli.shfile-mode coverage using new fixtures undertests/cli/test_data/. - Document shell completion setup and publish performance/benchmark guidance in the user manual, plans, and changelog.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
tests/test_cli.sh |
Reworks file-mode tests to use committed fixture files instead of temp files; adds broader file-mode scenarios. |
tests/cli/test_data/basic.dm |
Adds a baseline file-mode fixture (constants + arithmetic). |
tests/cli/test_data/comments.txt |
Adds a fixture covering comments/blank lines/inline comments/whitespace handling. |
tests/cli/test_data/edge_cases.dm |
Adds a fixture for zero/negative/unary minus/parentheses/power edge cases. |
tests/cli/test_data/precision.dm |
Adds high-precision stress fixture (repeating decimals, cancellation, near-integer constants). |
tests/cli/test_data/torture |
Adds complex-expression fixture to stress tokenizer/parser/evaluator paths. |
pixi.toml |
Ensures CLI binary is built before running tests and testcli. |
docs/user_manual_cli.md |
Adds “Shell Completions” section and a “Performance” section referencing the benchmark suite. |
docs/plans/cli_calculator.md |
Marks performance validation and CLI documentation items as completed with references. |
docs/changelog.md |
Documents shell completion docs and the new CLI benchmark suite. |
benches/run_bench.sh |
Adds cli as a benchmark type and dispatches to the new shell benchmark script. |
benches/cli/bench_cli.sh |
Introduces correctness + timing comparisons vs bc and python3 across multiple expressions/precisions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR expands the CLI’s documentation and validation tooling by adding an end-to-end benchmark suite (vs
bcandpython3) and improving CLI file-mode test coverage using checked-in fixture files.Changes:
benches/cli/bench_cli.shand wire it intopixi run bench cli.tests/test_cli.shfile-mode coverage using new fixtures undertests/cli/test_data/.