Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on enhancing the
BigInttype in thedecimojolibrary by adding multiplication functionality and comprehensive tests. The most important changes include the addition of themultiplyfunction, modifications to theBigIntstructure to support the new functionality, and the creation of extensive tests to ensure the correctness of the multiplication operation.Enhancements to
BigIntfunctionality:multiplyfunction to perform multiplication of twoBigIntnumbers insrc/decimojo/bigint/arithmetics.mojo.__mul__and__imul__methods to theBigIntstructure to support the multiplication operator.Modifications to
BigIntstructure:_words_typewithList[UInt32]for thewordsfield in theBigIntstructure.__init__methods to useList[UInt32]directly for initializing thewordsfield.is_one_or_minus_oneandis_negativeto theBigIntstructure for special case handling.Comprehensive tests for multiplication:
tests/bigint/test_bigint_multiply.mojowith extensive test cases covering basic multiplication, special cases, negative numbers, large numbers, and the commutative property.