Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes significant updates to the BigInt and BigUInt benchmark functionalities and arithmetic operations. The changes add new benchmark options and refactor the internal representation of BigInt operations to use the
magnitudeattribute instead ofwords.Benchmark Updates:
benches/bigint/bench.mojo: Added a new benchmark for floor division and updated the main function to include options for running different benchmarks.benches/biguint/bench.mojo: Updated the main function to include a menu for running different benchmarks.Refactoring BigInt Operations:
src/decimojo/bigint/arithmetics.mojo: Refactored theadd,subtract,multiply, andtruncate_dividefunctions to usemagnitude.wordsinstead ofwordsfor internal operations. This change affects how the arithmetic operations handle the internal representation of BigInt. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]New Functionality:
src/decimojo/bigint/arithmetics.mojo: Added a new functionfloor_divideto perform floor division on BigInt numbers, rounding towards negative infinity.