Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
BigIntandBigUIntbenchmarks and arithmetic operations. The changes improve the initialization and handling ofBigIntobjects, update the benchmarks to use more descriptive commands, and enhance the comparison operations. Below are the most important changes:Benchmark Improvements:
benches/bigint/bench.mojo: Added the import forbench_bigint_multiplyand updated the command options to use descriptive strings instead of numbers. [1] [2]benches/biguint/bench.mojo: Updated the command options to use descriptive strings instead of numbers.BigInt Initialization and Arithmetic Enhancements:
src/decimojo/bigint/arithmetics.mojo: Replaced theemptyandcapacityparameters withList[UInt32]for initializingBigIntobjects in various arithmetic functions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]BigInt Struct Enhancements:
src/decimojo/bigint/bigint.mojo: Deprecated theemptyandcapacityparameters inBigIntinitialization, introduced new constructors for safer initialization from lists and words, and added comparison dunders (__gt__,__ge__,__lt__,__le__,__eq__,__ne__). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Comparison Module Update:
src/decimojo/bigint/comparison.mojo: Removed unnecessary import and added the import forBigUInt.