Conversation
BigInt by using BigUInt's methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
BigIntandBigUIntstructures in thedecimojolibrary. The most important changes involve adding new methods, renaming and refactoring existing methods, and updating internal representation functions.Enhancements to
BigInt:__pow__methods to handle exponentiation with bothSelfandInttypes and the correspondingpowermethods for internal calculations. [1] [2]compare_absolutetocompare_magnitudesand reintroduced thecomparemethod. [1] [2]internal_representationmethod to useselfinstead ofvaluefor printing internal details.Enhancements to
BigUInt:comparemethod to a new location within the struct and adjusted thepowermethod to handle large exponents more robustly.internal_representationmethod to useselfinstead ofvaluefor printing internal details.Changes in
comparison.mojo:compare_absolutefunction tocompare_magnitudesto better reflect its purpose and updated references to it. [1] [2]