point the sample at the released bridge 1.0.1 from Maven Central#16
Merged
Conversation
Pre-release the sample reactor pinned bridge-common to the in-source
1.0-SNAPSHOT, which meant the sample build only worked after
`mvn install` of the library reactor had populated ~/.m2 first. Now
that 1.0.1 is published on Maven Central, switch the sample to that
released version so the CI example-build step (and any contributor
opening the sample tree on its own) resolves bridge artifacts directly
from repo1.maven.org without depending on a local library install.
- examples/.../pom.xml: <atlassian-runtime-bridge.version> 1.0-SNAPSHOT → 1.0.1
- examples/.../core/pom.xml: bridge-common version 1.0-SNAPSHOT → ${atlassian-runtime-bridge.version}
forge-connect/pom.xml and forge-container/pom.xml already used the
property, so no further changes are needed there.
Verified locally: `mvn -f examples/.../pom.xml clean install -DskipTests`
builds green against the published 1.0.1 jars.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…en badge and released dependency versions.
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-release the sample reactor pinned bridge-common to the in-source 1.0-SNAPSHOT, which meant the sample build only worked after
mvn installof the library reactor had populated ~/.m2 first. Now that 1.0.1 is published on Maven Central, switch the sample to that released version so the CI example-build step (and any contributor opening the sample tree on its own) resolves bridge artifacts directly from repo1.maven.org without depending on a local library install.forge-connect/pom.xml and forge-container/pom.xml already used the property, so no further changes are needed there.
Verified locally:
mvn -f examples/.../pom.xml clean install -DskipTestsbuilds green against the published 1.0.1 jars.