parameterize ProductAdaptersContractTest with @ParameterizedTest#4
Merged
vzakharchenko merged 1 commit intoMay 17, 2026
Merged
Conversation
Three nested classes (Jira/Confluence/Other) each ran the same five contract
assertions against a different stub adapter. JUnit 5 was designed for this
shape: one set of parameterized methods driven by a MethodSource that yields
the three stubs collapses 15 test methods into 5 and removes the
qlty:similar-code finding without weakening the contract.
The "{0}" display name and "adapters" source name are extracted into
constants so PMD's AvoidDuplicateLiterals stays quiet, and the source method
is annotated with @SuppressWarnings("UnusedMethod") because Error Prone
cannot see the string-based reflection link.
StubProductAdapterBase now declares abstract authenticatedAsAddon /
authenticatedAsCurrentUser / impersonation so the parameterized test can call
through the common base type while each concrete stub still satisfies its
specific *ProductAdapter interface.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
vzakharchenko
deleted the
refactor/parameterize-product-adapter-contract-test
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three nested classes (Jira/Confluence/Other) each ran the same five contract assertions against a different stub adapter. JUnit 5 was designed for this shape: one set of parameterized methods driven by a MethodSource that yields the three stubs collapses 15 test methods into 5 and removes the qlty:similar-code finding without weakening the contract.
The "{0}" display name and "adapters" source name are extracted into constants so PMD's AvoidDuplicateLiterals stays quiet, and the source method is annotated with @SuppressWarnings("UnusedMethod") because Error Prone cannot see the string-based reflection link.
StubProductAdapterBase now declares abstract authenticatedAsAddon / authenticatedAsCurrentUser / impersonation so the parameterized test can call through the common base type while each concrete stub still satisfies its specific *ProductAdapter interface.