drop redundant parameters from forgeApiContext test helper (qlty func…#5
Merged
vzakharchenko merged 1 commit intoMay 17, 2026
Merged
Conversation
…tion-parameters) All three callers passed the same class-level constants (INSTALLATION_ID, CLOUD_ID, CLIENT_KEY, SITE_URL) and the same objectMapper field. Only the optional principal varies between tests, so reading those values directly inside the helper shrinks the signature from 6 parameters to 1 (the principal, nullable for the "no FIT user" case) and closes the qlty:function-parameters finding. The helper is no longer static because it now reads the objectMapper instance field, but no caller relied on staticness. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vzakharchenko
force-pushed
the
refactor/simplify-forge-api-context-test-helper
branch
from
c7bfe85 to
7033b8f
Compare
|
Coverage Impact This PR will not change total coverage. 🚦 See full report on Qlty Cloud »🛟 Help
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tion-parameters)
All three callers passed the same class-level constants (INSTALLATION_ID, CLOUD_ID, CLIENT_KEY, SITE_URL) and the same objectMapper field. Only the optional principal varies between tests, so reading those values directly inside the helper shrinks the signature from 6 parameters to 1 (the principal, nullable for the "no FIT user" case) and closes the qlty:function-parameters finding.
The helper is no longer static because it now reads the objectMapper instance field, but no caller relied on staticness.