This repository was archived by the owner on Feb 4, 2026. It is now read-only.
FORGE-1497: Added support for current project injection#366
Conversation
ghost
assigned
Contributor
Contributor
1 similar comment
Contributor
Contributor
|
Build 151 outcome was FAILURE using a merge of 9965a8a Build problems:Failed tests detected Failed tests |
Contributor
Contributor
1 similar comment
Contributor
Contributor
|
Build 152 outcome was FAILURE using a merge of 9965a8a Build problems:Failed tests detected Failed tests |
Contributor
Contributor
|
Build 132 outcome was FAILURE using a merge of 70d2208 Build problems:Failed tests detected Failed tests |
1 similar comment
Contributor
|
Build 132 outcome was FAILURE using a merge of 70d2208 Build problems:Failed tests detected Failed tests |
Contributor
1 similar comment
Contributor
Contributor
|
Build 153 outcome was FAILURE using a merge of 70d2208 Build problems:Failed tests detected Failed tests |
Contributor
|
Build 131 outcome was FAILURE using a merge of 70d2208 Build problems:Failed tests detected Failed tests |
Contributor
|
Build 131 outcome was FAILURE using a merge of 70d2208 Build problems:Failed tests detected Failed tests |
Member
|
Hmmmm. I don't know about this. How would/should this behave when there is no project visible to the current UISelection? |
Contributor
|
Build 133 outcome was FAILURE using a merge of 70d2208 Build problems:Failed tests detected Failed tests |
1 similar comment
Contributor
|
Build 133 outcome was FAILURE using a merge of 70d2208 Build problems:Failed tests detected Failed tests |
Member
Author
|
I was expecting the injected Project to be null, but I have just created a test that asserts that null is never injected :( |
Contributor
Contributor
1 similar comment
Contributor
Contributor
|
Build 154 outcome was FAILURE using a merge of a350acf Build problems:Failed tests detected Failed tests |
Contributor
|
Build 134 outcome was FAILURE using a merge of a350acf Build problems:Failed tests detected Failed tests |
1 similar comment
Contributor
|
Build 134 outcome was FAILURE using a merge of a350acf Build problems:Failed tests detected Failed tests |
Member
Author
|
Marking as WON'T FIX since the concept of a current project no longer exists and it's retrievable via AbstractProjectCommand |
Member
|
Are you sure? I was expecting more of a fight about this but if not, that's
On Sat, Jan 25, 2014 at 10:59 PM, George Gastaldi
Lincoln Baxter, III |
Member
Author
|
Yeah, guess I am missing a valid use case for my previous impl. The Em domingo, 26 de janeiro de 2014, Lincoln Baxter, III <
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE THIS YET. Check this out. The only downside is that the project object is held in a Singleton, hence it won't work in a multi-user environment, but I think this is not a huge deal right now.