Skip to content

FORGEPLUGINS-148 Upgrade to java client 2.5.0#4

Closed
VineetReynolds wants to merge 1 commit intoforge:masterfrom
VineetReynolds:FORGEPLUGINS-148
Closed

FORGEPLUGINS-148 Upgrade to java client 2.5.0#4
VineetReynolds wants to merge 1 commit intoforge:masterfrom
VineetReynolds:FORGEPLUGINS-148

Conversation

@VineetReynolds
Copy link
Copy Markdown
Member

Corrected the RestService API usage to reflect changes done for
JBIDE-15429.

Also corrected the use of ICartridge and related classes as done
for JBIDE-13866.

Corrected the RestService API usage to reflect changes done for
JBIDE-15429.

Also corrected the use of ICartridge and related classes as done
for JBIDE-13866.
@VineetReynolds
Copy link
Copy Markdown
Member Author

Please don't merge without testing 😄 This wasn't a simple change to the POM.

@GrmpCerber
Copy link
Copy Markdown

Hi @VineetReynolds

I'm experiencing several problems with the current 2.0.1 client implementation (eg. space in passwords not supported, failure on deep internal errors, ...) so I'd like your pull request to be applied to the baseline plugin ;)

What did you meant by "Please don't merge without testing" ?
Have you tried it yet ?
had you experienced any problem ?

Regards

@VineetReynolds
Copy link
Copy Markdown
Member Author

Hi @GrmpCerber , I intended to submit this PR so that it could be tested and verified by the OpenShift team before merging. This is tested not only against some public OpenShift instance.

@lincolnthree can we get someone to test and merge this?

@lincolnthree
Copy link
Copy Markdown
Member

@VineetReynolds Yes. We need to find out who is responsible for this plugin now and get them to verify.

@kraman Do you know who has taken this over?

@lincolnthree
Copy link
Copy Markdown
Member

Out of date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants