Skip to content

Implemented FORGE-1254 and Unit Test #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gastaldi merged 1 commit into from
Jan 10, 2014
Merged

Implemented FORGE-1254 and Unit Test #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion impl/src/main/java/org/jboss/forge/parser/java/ast/ModifierAccessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,9 @@ public List<Modifier> clearVisibility(ASTNode body)

public void addModifier(ASTNode body, ModifierKeyword keyword)
{
getInternalModifiers(body).add(body.getAST().newModifier(keyword));
if (!hasModifier(body, keyword)) {
getInternalModifiers(body).add(body.getAST().newModifier(keyword));
Copy link
Copy Markdown
Member

@lincolnthree lincolnthree Jan 10, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thought. I guess I had originally assumed that the Eclipse JDT was "smart". Good fix!

}
}

public void removeModifier(ASTNode body, ModifierKeyword keyword)
Expand Down
27 changes: 27 additions & 0 deletions impl/src/test/java/org/jboss/forge/test/parser/java/MethodModifierTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
package org.jboss.forge.test.parser.java;

import static org.junit.Assert.assertEquals;

import java.io.InputStream;

import org.jboss.forge.parser.JavaParser;
import org.jboss.forge.parser.java.impl.MethodImpl;
import org.jboss.forge.parser.java.source.JavaClassSource;
import org.jboss.forge.parser.java.source.MethodSource;
import org.junit.Assert;
import org.junit.Test;

/**
* @author <a href="mailto:salemelrahal@gmail.com">Salem Elrahal</a>
*/
public class MethodModifierTest {

@Test
public void testDuplicateMethodModifier() throws Exception
{
MethodSource<JavaClassSource> method = JavaParser.create(JavaClassSource.class).addMethod("public static void test()");
((MethodImpl<?>)method).setStatic(true);
Assert.assertFalse(method.toString().contains("static static"));
Assert.assertTrue(method.toString().contains("static"));
}
}