Add Server QuickConnect#2
Merged
Merged
Conversation
MichaelHillcox
left a comment
MichaelHillcox
left a comment
There was a problem hiding this comment.
Only one question, other than that, this looks good. I'd like to see a readme update if you have time, otherwise, not too concerned :D
MichaelHillcox
approved these changes
Aug 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new config option to client configs, allowing users to auto connect to a server after initial game launch.
System will be ignored if user specifies an empty string or invalid ip.
Example config:
client = {quickPlayServer = "<server ip>"}The vanilla quick play system takes priority over this config, meaning that if a user uses the vanilla launcher to launch via quick play, the config option will be ignored and client will be connected to the vanilla quick play option instead.
NeoForge version has been bumped to latest, this was mainly to test auto connecting to the forgecraft server.
mods required newer neo version than was currently being setup.