feat: Add Infinite Scroll Pagination on Homepage #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GV14982
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We needed to show more than just the first page of recipes. I setup a new route for fetching paginated recipes, and added the logic to the
RecipeListcomponent.I also moved the loader logic into a common function, since both that pagination loader and the main loader for the page are almost identical. I initially tried to just revalidate the existing one, but getting the cursor into the loader was gonna be weird. I didn't want to use path or query params because I wanted the URL to be stable (Although we may need to revisit this).
Checklist
Related Issues
Closes #61