clear dirty after full render #143
Conversation
Issue: Flickery TUI apps in Architect; full-screen sessions keep dirty set so idle throttling never engages. Solution: Clear SessionState.dirty after a successful full render to match cached grid behavior.\nDocument the dirty-flag lifecycle so future render changes keep idle throttling intact.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f6028ed40c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Pull request overview
This PR ensures that full-screen session renders can properly enter idle throttling by clearing the dirty flag after successful rendering, matching the behavior already present for cached grid renders.
Changes:
- Clear
SessionState.dirtyflag after successful full render inrenderSession - Document the dirty-flag lifecycle in the architecture overview
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/render/renderer.zig | Added session.dirty = false; after rendering session content and overlays |
| docs/architecture.md | Added documentation explaining when SessionState.dirty is set and cleared |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Refs: PR#143 comment 2704562395 Solution: mark the focused session dirty when a collapse completes so the grid cache updates before idle throttling resumes.
Solution