refactor: remove unused declarations flagged by the linter#327
Merged
Conversation
Issue: The dead-code linter reported four public declarations that no code references: two SDL renderer flag constants in c.zig, fillCircle in gfx/primitives.zig, and keyToChar in input/mapper.zig. Solution: Remove all four after confirming no callers exist anywhere in the repo. VSync is configured through SDL_SetRenderVSync rather than the renderer flags, and key encoding goes through encodeKey rather than the char-mapping helper, so nothing depends on the removed code.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ed79628fba
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The gfx/* module table in ARCHITECTURE.md still advertised filled circles and fillCircle() after the function was removed. Update the description and helper list so the rendering utility surface matches the code. Addresses review comment on PR #327.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution
The dead-code linter flagged four public declarations with no callers anywhere in the repo. This PR removes them:
src/c.zig— theSDL_RENDERER_ACCELERATEDandSDL_RENDERER_PRESENTVSYNCflag constants. VSync is set throughSDL_SetRenderVSync, so these flags were never read.src/gfx/primitives.zig—fillCircle, which nothing drew.src/input/mapper.zig—keyToChar. Key-to-escape-sequence encoding goes throughencodeKey, not this char-mapping helper.Each symbol was checked with a repo-wide search before removal: only its definition site turned up, with no references in source or tests. No behavior changes, no documentation referenced these symbols.
zig build,zig build test, andjust lintall pass clean, and the lint that previously reported the four warnings now shows no issues.