build(nix): bump SDL3 from 3.4.0 to 3.4.10#329
Merged
Conversation
Issue: SDL3 was pinned to 3.4.0 via a Nix overlay; 3.4.10 is the current stable release. Solution: Updated the overlay with the new version string and NAR hash, renamed the overlay file to match the version, and updated the flake.nix import. Fixes in this range worth noting: 3.4.4 reverted an accidental sRGB framebuffer default that could affect rendering colors, and 3.4.6 fixed multi-threaded GPU crashes on Metal and Vulkan.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 31d014cc19
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps SDL3 from 3.4.0 to 3.4.10 by updating the Nix overlay and its source hash.
Solution
The overlay was pinned to SDL3 3.4.0. 3.4.10 is the current stable release, ten patch versions ahead with no API changes.
The overlay file is renamed from
sdl3-3-4-0.nixtosdl3-3-4-10.nixwith the updated version string and NAR hash.flake.nixpoints to the new file.A few fixes in this range are worth mentioning. In 3.4.4, SDL reverted
SDL_GL_FRAMEBUFFER_SRGB_CAPABLEto default 0 after an accidental change caused incorrect colors in OpenGL rendering. In 3.4.6, multi-threaded GPU crashes on Metal and Vulkan were fixed. Neither is likely to cause visible changes here, but both are good to have.