Merged
Conversation
Prompt: We do a small pause before showing the long press animation. This was added recently. But I noticed that the animation itself (when the ring briefly increases and decreases in diameter) now doesn't complete, the ring just disappears. I have a suspicion something with the timing is off now. Please make sure the ring appears after a delay but its animation then runs until completion. Solution: Adjusted ESC hold indicator timing to use the visible window after the pre-appearance delay so segments complete and the ring pulses; documented the behavior in README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solution\n- ESC hold indicator now divides arc timing across the visible duration after the 150ms delay so the ring fills and pulses instead of vanishing.\n- README notes that the ring appears after a short pause and completes its animation.\n\n## Testing\n- zig build\n- zig build test