fix(syntaxis): async mock extract to match ergasia DownloadEngine trait - #493
Merged
Conversation
#491 (ergasia) changed DownloadEngine::extract to async (impl Future) so extraction runs off the executor; #489 (syntaxis) merged a test MockEngine whose extract was still sync. The two PRs were each internally consistent but ergasia was tested pre-syntaxis, so the stale mock only broke the workspace build once both landed. Make the mock extract async. Gate-Passed: kanon 0.1.5 +stages:fmt,check,clippy,nextest,lint sha:77b78bec2dcb0e1e949146db9e7a348590cc816e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repairs a workspace build break on
main.#491 (ergasia) changed
DownloadEngine::extractto async (impl Future) so extraction runs off the executor. #489 (syntaxis) merged a testMockEnginewhoseextractwas still sync. Each PR was internally consistent and individually green, but #491 was rebased/tested against pre-#489 main, so the stale mock only broke the workspace build once both landed —cargo clippy/test --workspaceis red atf8ec16e(E0277: the syncextractresult is not a future).One-line fix: make the mock
extractasync fn.kanon gate --fullgreen (full workspace clippy + nextest).