fix(serving): low-severity audit batch findings (paroche/syndesis/archon/akouo) - #505
Merged
Conversation
…hon/akouo) Applies the verified low-severity findings across the serving/audio/render crates, including the advertised OPDS authors shelf, plus added coverage. Closes #383 Closes #465 Closes #384 Closes #439 Closes #437 Closes #436 Gate-Passed: kanon 0.1.5 +stages:fmt,check,clippy,nextest,lint sha:939b0302fe6b7191ac27da006a336d0fcbe98fc9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Low-severity audit-batch findings across the serving/audio/render crates
(paroche, syndesis, archon, akouo), plus added test coverage.
Rebased onto current
main(after the core/acquisition/media batches landed).The cross-crate pagination fix that several batches touched is resolved to
main's canonical
u32list_requests/count_requestssignature; serving'sduplicate
i64variant was dropped. Serving's unique fixes are preserved:parse_search_media_typeinvalidmedia_typenow maps to a400-class
ServiceError::InvalidInputinstead ofInternal(500); coexistswith main's
spawn_blockingconfig reload.PairingGate): on/off switch + afixed-window rate limit on
is_newpairing attempts, which mint an API keyfor an unauthenticated peer.
Page::newAPI.Gate:
kanon gate --fullgreen (fmt, check, clippy-D warnings --all-targets,nextest 1700/1700, deny, lint).
Closes #383
Closes #465
Closes #384
Closes #439
Closes #437
Closes #436