fix(ci): dispatch the binary release build from release-please itself - #739
Merged
Conversation
release.yml's tag-push trigger has never fired: release-please tags with a workflow-issued token, and GitHub's recursion guard drops workflow triggers from events that token produces. The only path to platform binaries has been the workflow_dispatch fallback, run by hand — and nobody has run it since v0.3.0. v0.4.0, v0.4.1, and v0.4.2 each shipped only the 5 auto-attached source/SBOM/provenance assets, zero binaries (harmonia#709). Add trigger-binary-release to release-please.yml: gated on release_created, it runs in the ordinary push-to-main context that merged the release PR, not the tag push, so the recursion guard does not apply — the same reason attest-release-source already fires reliably every release. It dispatches release.yml explicitly via the Actions API instead of depending on the tag trigger, so a release cut no longer needs anyone to remember the manual step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finding
release.yml'son: push: tags:trigger has never fired.release-pleasepushes the release tag using a workflow-issued token (
RELEASE_PLEASE_TOKENor the fallback
GITHUB_TOKEN), and GitHub's recursion guard drops workflowtriggers from events that a workflow-issued token produces. The workflow's
own header comment already documented this; the only working path to
platform binaries has been the
workflow_dispatchfallback, run by hand.Nobody has run it since v0.3.0.
#709 named this exact root cause.
Evidence
Same 5 source/SBOM/provenance assets, zero
harmonia-*-{x86_64,aarch64}-*binary tarballs, on v0.4.0, v0.4.1, and v0.4.2 — three releases running.
Contrast v0.3.0, which carries 15 additional binary-related assets (3
platforms × 5 files each) from the one hand-run dispatch.
5 runs total, all
workflow_dispatch, nonepush. Most recent 2026-08-12,despite v0.4.0 (08-19), v0.4.1 (08-24), v0.4.2 (08-26) all publishing since.
Why this matters
The release train is supposed to produce attested platform binaries per
release; instead it quietly ships source-only releases unless a human
remembers a manual step that has a 100% miss rate since the last time
someone happened to run it.
Desired correction
Dispatch
release.ymlfrom insiderelease-please.yml's ownrelease_created-gated job, the same patternattest-release-sourcealready uses successfully — that job runs in the push-to-main context
(not the tag push), so it isn't subject to the recursion guard, and it has
fired reliably on every release since it was added.
trigger-binary-releasecallsgh workflow run release.yml --ref <tag_name>with a job-scopedactions: writetoken, so the dispatch firesunconditionally on every
release_created == true, no memory required.Done when: a release cut needs no manual dispatch for binaries to
land — verified by the next release-please merge producing binary assets
without anyone running
workflow_dispatchby hand.Closes #709