Fix confusing error when release binaries not yet available#18
Merged
Conversation
When a release exists on GitHub but the cross-compilation workflow hasn't finished uploading binaries, `lattice update` now shows "Release vX.Y.Z exists but binaries are not yet available" instead of the confusing "No asset found for target <url>" error. Checks the release's asset list from the GitHub API before attempting download. Also extracts shared parse_release_response to eliminate duplication between fetch_latest_version and fetch_specific_version. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lattice updatenow shows a clear error when a release exists but binaries haven't been uploaded yet (e.g., release workflow still building)Error: No asset found for target https://github.com/.../lattice-0.1.15-aarch64-apple-darwin.tar.gzError: Release v0.1.15 exists but binaries are not yet available (release may still be building)Changes
AssetsNotReadyerror variant with descriptive messageReleaseInfostruct to carry release metadata (tag, version, asset names)parse_release_responseto share betweenfetch_latest_versionandfetch_specific_versionTest plan
make pre-commitpasses (fmt + clippy)lattice updatewhile v0.1.15 release workflow was still building🤖 Generated with Claude Code