Fix font style selection ignoring user-selected weight/italic/underline#19
Merged
forloopcodes merged 4 commits intomainfrom Feb 4, 2026
Merged
Conversation
- Store font weight, italic, and underline attributes in AppState - Update FormatFont() to preserve font style from ChooseFontW dialog - Update ApplyFont() to use stored attributes instead of hardcoded FW_NORMAL - This ensures selected font style (Regular, Bold, Italic) is properly applied Co-authored-by: ForLoopCodes <89027512+ForLoopCodes@users.noreply.github.com>
Co-authored-by: ForLoopCodes <89027512+ForLoopCodes@users.noreply.github.com>
Co-authored-by: ForLoopCodes <89027512+ForLoopCodes@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix loading of regular TECHNICAL font in legacy notepad x64
Fix font style selection ignoring user-selected weight/italic/underline
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Font dialog selections were ignored during font creation. Selecting "TECHNICAL Regular" rendered as Bold because
CreateFontWalways used hardcodedFW_NORMALinstead of the user's chosen style.Changes
fontWeight,fontItalic,fontUnderlinefields to persist font attributeslfWeight,lfItalic,lfUnderlinefromChooseFontWresultCreateFontWBefore/After
Affects all fonts with multiple weight/style variants, not just TECHNICAL.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.