fix: fix arity error panic

[ascandone]

No description provided.

[coderabbitai]

Walkthrough

Added safety guards to prevent out-of-bounds access in arity checking for specific built-in functions (balance, overdraft, get_asset) by conditionally performing unification only when sufficient arguments are present. A corresponding test validates the BadArity diagnostic.

Changes

Cohort / File(s)	Summary
Arity Validation Guards internal/analysis/check.go	Added conditional guards in checkFnCallArity to prevent out-of-bounds unification: balance/overdraft calls only unify second argument if >1 arg exists; get_asset calls only unify first argument if ≥1 arg exists.
Arity Test Coverage internal/analysis/check_test.go	Added TestBadArity test function that validates BadArity diagnostic (Expected 2, Actual 1) for under-specified function calls.

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 Bounds we guard with watchful care,
Arguments checked here and there,
No more crashes from the past,
Safety first, made to last! ✨

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check	❓ Inconclusive	No pull request description was provided by the author, making it impossible to assess whether the description relates to the changeset.	Add a pull request description explaining the arity error panic issue, why guards are needed, and the impact of the fix.

✅ Passed checks (1 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: fixing an arity error panic. The changeset adds guards to conditional unification logic to prevent out-of-bounds access when arguments are fewer than expected.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/fix-arity-error-panic

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.90%. Comparing base (aee5218) to head (d0c0553).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   67.75%   67.90%   +0.15%     
==========================================
  Files          45       45              
  Lines        4425     4427       +2     
==========================================
+ Hits         2998     3006       +8     
+ Misses       1264     1260       -4     
+ Partials      163      161       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.