Skip to content

Conversation

@paul-nicolas
Copy link
Contributor

No description provided.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 18, 2025

Important

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

101 files out of 230 files are above the max files limit of 100. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/bank-bridge-plaid

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

❌ Patch coverage is 58.50058% with 1799 lines in your changes missing coverage. Please review.
✅ Project coverage is 68.74%. Comparing base (6d43a24) to head (76ee5e5).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ternal/connectors/plugins/public/plaid/webhooks.go 25.63% 235 Missing ⚠️
internal/connectors/plugins/registry/wrapper.go 0.00% 136 Missing ⚠️
internal/models/psu_bank_bridge_connections.go 0.00% 114 Missing ⚠️
internal/connectors/engine/activities/activity.go 0.00% 112 Missing ⚠️
internal/connectors/engine/engine.go 78.74% 90 Missing and 8 partials ⚠️
internal/events/bank_bridge.go 0.00% 74 Missing ⚠️
...rs/plugins/public/plaid/client/client_generated.go 51.70% 71 Missing ⚠️
...onnectors/plugins/public/plaid/update_user_link.go 0.00% 67 Missing ⚠️
internal/models/plugin_generated.go 6.94% 67 Missing ⚠️
...s/plugins/public/plaid/client/create_link_token.go 0.00% 51 Missing ⚠️
... and 87 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #499      +/-   ##
==========================================
- Coverage   69.56%   68.74%   -0.82%     
==========================================
  Files         626      715      +89     
  Lines       32302    36814    +4512     
==========================================
+ Hits        22470    25308    +2838     
- Misses       8588    10184    +1596     
- Partials     1244     1322      +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@paul-nicolas paul-nicolas force-pushed the feat/bank-bridge-plaid branch from 20a1b03 to acdf77c Compare July 22, 2025 13:07
@paul-nicolas paul-nicolas marked this pull request as ready for review July 22, 2025 13:10
@paul-nicolas paul-nicolas requested a review from a team as a code owner July 22, 2025 13:10
cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

@fguery fguery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's do a demo tomorrow 😂

@fguery
Copy link
Contributor

fguery commented Jul 23, 2025

I note that we have a lot of communality between this PR and what would be required to support oauth "3 legged" in other "classic" PSP.
I don't think it's worth changing this in this PR, but food for thought

cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

@fguery fguery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didnt' mean to answer as another review, oops

@paul-nicolas paul-nicolas force-pushed the feat/bank-bridge-plaid branch from a55b484 to 4c896ce Compare July 28, 2025 08:28
@paul-nicolas paul-nicolas force-pushed the feat/bank-bridge-plaid branch 2 times, most recently from 0b52402 to 053bb80 Compare July 29, 2025 08:24
@laouji
Copy link
Contributor

laouji commented Jul 29, 2025

28.00% of diff hit (target 69.55%)

Might be nice if you tried to increase the code coverage for the new code you added though 🙂

@paul-nicolas paul-nicolas force-pushed the feat/bank-bridge-plaid branch from e0e1a04 to 76ee5e5 Compare July 30, 2025 13:17
@paul-nicolas paul-nicolas added this pull request to the merge queue Jul 30, 2025
Merged via the queue into main with commit e557202 Jul 30, 2025
7 of 9 checks passed
@paul-nicolas paul-nicolas deleted the feat/bank-bridge-plaid branch July 30, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants