chore(docker): upgrade ubuntu to 24.04 and pin alpine to 3.22#1953
chore(docker): upgrade ubuntu to 24.04 and pin alpine to 3.22#1953flemzord merged 1 commit intorelease/v3.0from
Conversation
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughUpdated base images in Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
base.Dockerfile (1)
4-6: The alpine “certs” stage is now unused; remove it or switch COPY back.Since CA certs are copied from the base stage (Line 8), this stage is built but unused, slowing builds.
Apply this diff to drop the unused stage:
-FROM alpine:3.22 AS certs -RUN apk --update add ca-certificatesIf you intentionally keep this stage, prefer no-cache:
-RUN apk --update add ca-certificates +RUN apk add --no-cache ca-certificatesAlso consider removing
curlfrom the base stage if not used elsewhere to speed builds.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
base.Dockerfile(1 hunks)
🔇 Additional comments (2)
base.Dockerfile (2)
1-1: Ubuntu 24.04 upgrade looks good; consider pin-by-digest.LGTM. For reproducible builds, consider pinning to a specific patch tag or digest (e.g., ubuntu:24.04@sha256:...). Also confirm downstream assumptions about Debian paths remain valid.
8-8: Switching CA copy to base stage is fine. Verify bundle path presence.Debian/Ubuntu’s bundle at /etc/ssl/certs/ca-certificates.crt is correct. Just ensure the file exists post-install on 24.04 in CI.
Signed-off-by: Sylvain Rabot <sylvain@formance.com>
No description provided.