Skip to content

chore(docker): upgrade ubuntu to 24.04 and pin alpine to 3.22#1953

Merged
flemzord merged 1 commit intorelease/v3.0from
upgrade-base
Oct 16, 2025
Merged

chore(docker): upgrade ubuntu to 24.04 and pin alpine to 3.22#1953
flemzord merged 1 commit intorelease/v3.0from
upgrade-base

Conversation

@sylr
Copy link
Contributor

@sylr sylr commented Oct 14, 2025

No description provided.

@sylr sylr requested a review from a team as a code owner October 14, 2025 07:11
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 14, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Walkthrough

Updated base images in base.Dockerfile: Ubuntu bumped from 22.04 → 24.04 and the certs stage pinned from alpine:latestalpine:3.22. No functional build-step changes or COPY instruction changes were observed in the diff.

Changes

Cohort / File(s) Summary
Docker base image updates
base.Dockerfile
Bumped Ubuntu base from 22.04 to 24.04; pinned certs stage from alpine:latest to alpine:3.22. No other build steps or COPY changes detected in the diff.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

A rabbit nibbles bytes in morning light,
Bumped the base to newer height.
Alpine pinned, the layers tight,
Images ready, snug and bright—
Hopping off into the night. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description Check ⚠️ Warning The pull request lacks any description, so there is no context or summary provided to explain the changes, leaving reviewers without guidance on the purpose or scope of the updates. Please add a brief description summarizing the purpose of the Docker image upgrades and pinning changes to help reviewers understand the intent and implications of this update.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title accurately and concisely describes the two main updates to the Docker base images, matching the changes in the Dockerfile without unnecessary detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch upgrade-base

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 11ef345 and d7f434d.

📒 Files selected for processing (1)
  • base.Dockerfile (1 hunks)
🔇 Additional comments (1)
base.Dockerfile (1)

4-4: Confirmed alpine:3.22 tag exists on Docker Hub Verified via manifest API; no further action needed.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

cursor[bot]

This comment was marked as outdated.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
base.Dockerfile (1)

4-6: The alpine “certs” stage is now unused; remove it or switch COPY back.

Since CA certs are copied from the base stage (Line 8), this stage is built but unused, slowing builds.

Apply this diff to drop the unused stage:

-FROM alpine:3.22 AS certs
-RUN apk --update add ca-certificates

If you intentionally keep this stage, prefer no-cache:

-RUN apk --update add ca-certificates
+RUN apk add --no-cache ca-certificates

Also consider removing curl from the base stage if not used elsewhere to speed builds.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3c1ca75 and 11ef345.

📒 Files selected for processing (1)
  • base.Dockerfile (1 hunks)
🔇 Additional comments (2)
base.Dockerfile (2)

1-1: Ubuntu 24.04 upgrade looks good; consider pin-by-digest.

LGTM. For reproducible builds, consider pinning to a specific patch tag or digest (e.g., ubuntu:24.04@sha256:...). Also confirm downstream assumptions about Debian paths remain valid.


8-8: Switching CA copy to base stage is fine. Verify bundle path presence.

Debian/Ubuntu’s bundle at /etc/ssl/certs/ca-certificates.crt is correct. Just ensure the file exists post-install on 24.04 in CI.

Signed-off-by: Sylvain Rabot <sylvain@formance.com>
@flemzord flemzord added this pull request to the merge queue Oct 16, 2025
Merged via the queue into release/v3.0 with commit 7339e66 Oct 16, 2025
4 checks passed
@flemzord flemzord deleted the upgrade-base branch October 16, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants