Skip to content

feat(auth): backport multi-issuer JWT validation to v2 go-libs#1980

Merged
sylr merged 1 commit intorelease/v2.0from
feat/v2.0+multi-issuers
Mar 3, 2026
Merged

feat(auth): backport multi-issuer JWT validation to v2 go-libs#1980
sylr merged 1 commit intorelease/v2.0from
feat/v2.0+multi-issuers

Conversation

@sylr
Copy link
Contributor

@sylr sylr commented Mar 3, 2026

Summary

  • Backports multi-issuer JWT validation from go-libs v3 (commit 33a9429) to the in-repo libs/go-libs/auth/ package
  • Replaces the single-issuer model (with hardcoded http://auth:8080/keys endpoint hack) with proper OIDC discovery per issuer
  • Adds --auth-issuers CLI flag (StringSlice) alongside the existing --auth-issuer for backward compatibility
  • Zero changes to component code — only libs/go-libs/auth/ files are modified

Test plan

  • cd libs/go-libs && go build ./auth/... — compiles
  • cd components/payments && go build ./... — compiles
  • cd components/ledger && go build ./... — compiles
  • cd ee/webhooks && go build ./... — compiles
  • cd ee/wallets && go build ./... — compiles
  • cd ee/reconciliation && go build ./... — compiles
  • Deploy with --auth-issuers=<issuer1>,<issuer2> and verify tokens from both issuers are accepted
  • Deploy with only --auth-issuer=<issuer> (deprecated) and verify backward compatibility

🤖 Generated with Claude Code

Support multiple trusted OIDC issuers for JWT validation, replacing
the single-issuer model with hardcoded auth endpoint. Each issuer
gets its own OIDC discovery and key set, with tokens routed to the
correct verifier by pre-parsing the iss claim.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 3, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/v2.0+multi-issuers

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sylr sylr changed the base branch from release/v2.0.0-main to release/v2.0 March 3, 2026 10:27
@sylr sylr merged commit adcd2c9 into release/v2.0 Mar 3, 2026
23 of 24 checks passed
@sylr sylr deleted the feat/v2.0+multi-issuers branch March 3, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant