[codex] Restore selected old PR fixes#175
Merged
Merged
Conversation
Port the safe parts of old pull requests formapro#137 and formapro#141 onto the revived codebase. Return BadRequestHttpException when the UniqueEntity Ajax endpoint receives a malformed request without the required data payload, and cover that behavior in the controller test. Fix collection prototype id generation so addPrototype does not duplicate the parent id prefix, while keeping preparePrototype backward-compatible with callers that pass an explicit id segment. Add JavaScript regression coverage for preparePrototype and addPrototype id generation. Validation: php /tmp/jsfv-composer.phar validate --strict; php /tmp/jsfv-composer.phar test; npm test; git diff --check. Co-authored-by: Codex <codex@openai.com>
This was referenced Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
datapayload.addPrototype()creates a new child.preparePrototype()andaddPrototype()id generation.Why
The old PRs were conflicting after the Symfony revival, but both contained small valid fixes that can be applied cleanly to the modernized codebase. These changes preserve the existing public behavior where possible:
preparePrototype()still accepts an explicit id segment, but defaults to the item name whenaddPrototype()is the caller.Validation
php /tmp/jsfv-composer.phar validate --strictphp /tmp/jsfv-composer.phar testnpm testgit diff --check