revert(deps): revert gazelle migration phases 1-3#6205
Merged
Conversation
Revert the BUILD file changes from phases 1-3 of the gazelle migration: - Phase 1: inline ts_binary -> js_binary (#6197) - Phase 2: decompose ts_compile macros (#6198) - Phase 3+4: decompose vitest, enable gazelle JS (#6199) Keep gazelle scaffolding (aspect-gazelle setup, multitool, lefthook integration) and knowledge-base documentation. The migration approach of using map_kind + copy_to_bin caused conflicting actions between gazelle-managed srcs and copy_to_bin outputs. A different approach is needed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Revert the BUILD file changes from the gazelle migration (phases 1-3) while keeping the scaffolding and documentation.
Reverted
ts_binary→js_binaryinlining (refactor(deps): gazelle migration phase 1 — inline thin wrappers #6197)ts_compilemacro decomposition (refactor(deps): gazelle migration phases 2-3 — decompose ts_compile and vitest macros #6198)vitestdecomposition + gazelle JS enablement (refactor(deps): gazelle migration — enable automatic dep management for all packages #6199)Kept
Why
The
map_kind+copy_to_binapproach caused conflicting actions — bothcopy_to_bin(name = "srcs")and gazelle's direct file lists produce the same output files throughts_project. A different approach is needed that either eliminatescopy_to_binor uses a custom gazelle extension.Test plan
🤖 Generated with Claude Code