Skip to content

fix(@formatjs/cli-lib): handle literal Windows compile paths#6607

Merged
longlho merged 1 commit into
mainfrom
codex/fix-cli-lib-windows-paths
May 22, 2026
Merged

fix(@formatjs/cli-lib): handle literal Windows compile paths#6607
longlho merged 1 commit into
mainfrom
codex/fix-cli-lib-windows-paths

Conversation

@longlho
Copy link
Copy Markdown
Member

@longlho longlho commented May 22, 2026

Summary

  • treat existing translation file inputs as literal files before glob expansion in the Rust compile path
  • cover literal file paths that include glob metacharacters
  • extend the Windows native binding smoke test to call compile() with a native Windows path

Fixes #6603

Test Plan

  • bazel test //crates/formatjs_cli:formatjs_cli_test
  • bazel build //packages/cli-native-darwin-arm64:pkg
  • node smoke test against bazel-bin/packages/cli-native-darwin-arm64/pkg
  • git diff --check

Note: local pre-commit was bypassed because format-oxfmt could not load @oxfmt/binding-darwin-arm64 from the local pnpm install.

@longlho longlho enabled auto-merge May 22, 2026 01:16
@longlho longlho added this pull request to the merge queue May 22, 2026
Merged via the queue into main with commit 24ea424 May 22, 2026
9 checks passed
@longlho longlho deleted the codex/fix-cli-lib-windows-paths branch May 22, 2026 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compile using @formatjs/cli-lib on Windows doesn't work

1 participant