Skip to content

fix: fixes backing data empty list bug#52

Merged
pandeymangg merged 2 commits into
mainfrom
fix/backing-data-nil
May 21, 2026
Merged

fix: fixes backing data empty list bug#52
pandeymangg merged 2 commits into
mainfrom
fix/backing-data-nil

Conversation

@pandeymangg
Copy link
Copy Markdown
Contributor

fixes a bug with the backing data which made display once once and display until responded options for the surveys not work

@pandeymangg pandeymangg requested a review from Dhruwang May 21, 2026 12:12
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

Review Change Stack

Walkthrough

This PR makes two independent updates: Maven publishing is now unconditionally signed for all publications via signAllPublications(), and user state synchronization logic changes to trigger syncing when expiration is reached or passed (using !Date().before(expiresAt)) and clears in-memory caches by nulling backing fields instead of assigning empty lists, permitting SharedPreferences-backed getters to reload persisted data.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title directly describes the main change: fixing a backing data empty list bug, which matches the core modification in UserManager.kt where empty lists are replaced with null values.
Description check ✅ Passed The description is related to the changeset, explaining the bug fix impact on survey display options, which corresponds to the backing data handling changes in UserManager.kt.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@android/build.gradle.kts`:
- Line 98: The change enabling signAllPublications() causes all publish tasks
(including publishToMavenLocal) to fail when GPG creds are not configured;
modify the build so signing only runs when credentials are present or in CI:
detect signing properties (signing.*) or ORG_GPG_* env vars (or a custom gradle
property like requireSigning=true) before invoking signAllPublications(), and/or
skip signing for local tasks such as publishToMavenLocal; also consider moving
this signing change into its own PR separate from the "fixes backing data empty
list bug" work.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 9d72113f-ac18-4f62-a76d-9dfa6c55ee67

📥 Commits

Reviewing files that changed from the base of the PR and between 7d2ffab and cc9e032.

📒 Files selected for processing (2)
  • android/build.gradle.kts
  • android/src/main/java/com/formbricks/android/manager/UserManager.kt

Comment thread android/build.gradle.kts
@sonarqubecloud
Copy link
Copy Markdown

@pandeymangg pandeymangg enabled auto-merge May 21, 2026 12:47
@pandeymangg pandeymangg requested a review from mattinannt May 21, 2026 13:24
@pandeymangg pandeymangg added this pull request to the merge queue May 21, 2026
Merged via the queue into main with commit a24ed3f May 21, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants