Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
WalkthroughThe changes update the text labels and styling in survey response download interfaces and add corresponding localization entries. The 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (5)
packages/lib/messages/fr-FR.json (1)
1749-1750: Ensure Consistency with Case Requirements for Button LabelsThe new localization keys
"filtered_responses_csv"and"filtered_responses_excel"have been added with translations:
"Réponses filtrées (CSV)""Réponses filtrées (Excel)"Per the PR objective—to have the word "responses" rendered in lowercase for the download responses button—please confirm whether this case requirement applies to the French translations as well. If so, consider changing the translation to use a lowercase initial letter (e.g.,
"réponses filtrées (CSV)"and"réponses filtrées (Excel)") unless there’s a specific design guideline for French that favors capitalization.packages/lib/messages/de-DE.json (1)
1749-1750: Localization Keys for Filtered Downloads AddedThe new entries for
"filtered_responses_csv"and"filtered_responses_excel"have been added to support the updated button label for downloading filtered responses. In the English UI, the fix ensures the word "responses" appears in lowercase. In the German localization, the noun “Antworten” is naturally capitalized; please verify that this capitalization is acceptable per German UI standards, or if consistency demands a stylistic adjustment for this button label.packages/lib/messages/pt-BR.json (1)
1749-1750: New Localization Entries for Filtered ResponsesThe two new keys (
"filtered_responses_csv"and"filtered_responses_excel") have been added to support the updated UI for downloading filtered responses. The texts appear consistent with similar entries in other localization files.Consider verifying that the casing in the Portuguese translation meets the design requirements. If the PR objective is to have the word “responses” in lowercase, you might want to review whether "Respostas" (with an initial uppercase letter) is acceptable for the target audience or if it should be “respostas” instead.
apps/web/modules/ui/components/data-table/components/selected-row-settings.tsx (1)
79-81: Enforce Lowercase Styling for Selected Row InformationThe
<div>now explicitly includes the Tailwind CSSlowercaseutility class which ensures that the selected row count and type are displayed entirely in lowercase. This update directly supports the UI fix by enforcing the intended button label style.packages/lib/messages/pt-PT.json (1)
1749-1750: Ensure Consistent Lowercase for "responses" in Button LabelsThe new translation keys for filtered responses use the value
"Respostas filtradas (CSV)"and"Respostas filtradas (Excel)". Per the PR objective to display the word "responses" in lowercase on the download button, please verify that the Portuguese translation should follow this convention. If the design requires the term to be in lowercase (e.g."respostas filtradas (CSV)"and"respostas filtradas (Excel)"), kindly update the values accordingly.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (8)
apps/web/app/(app)/environments/[environmentId]/surveys/[surveyId]/components/CustomFilter.tsx(2 hunks)apps/web/modules/ui/components/data-table/components/selected-row-settings.tsx(1 hunks)packages/lib/messages/de-DE.json(1 hunks)packages/lib/messages/en-US.json(1 hunks)packages/lib/messages/fr-FR.json(1 hunks)packages/lib/messages/pt-BR.json(1 hunks)packages/lib/messages/pt-PT.json(1 hunks)packages/lib/messages/zh-Hant-TW.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: Run E2E Tests / Run E2E Tests
- GitHub Check: Run Unit Tests / Unit Tests
- GitHub Check: Build Formbricks-web / Build Formbricks-web
- GitHub Check: Validate Docker Build
- GitHub Check: SonarQube
- GitHub Check: Analyze (javascript)
- GitHub Check: Tusk Tester
🔇 Additional comments (5)
packages/lib/messages/zh-Hant-TW.json (1)
1749-1750: New Localization Keys for Filtered ResponsesThe localization file now includes two new keys,
"filtered_responses_csv"and"filtered_responses_excel", with values"篩選回應 (CSV)"and"篩選回應 (Excel)"respectively. These entries are consistent with similar additions in other language files and help ensure that the “download responses” button label uses the correct (lowercase) terminology. Even though Chinese characters do not have upper- or lowercase forms, the added keys mirror the change made in the other locales.Please verify that these new keys are used in the UI and that they match the design requirements outlined in the PR.
packages/lib/messages/en-US.json (1)
1749-1750: Updated Localization Keys for Download Responses ButtonThe new entries
"filtered_responses_csv": "Filtered responses (CSV)"and"filtered_responses_excel": "Filtered responses (Excel)"correctly implement the change to display the word “responses” in lowercase. This aligns with the PR’s objective to update the button label. Please ensure that the corresponding UI components (e.g., in the CustomFilter component) are referencing these new keys instead of the old ones (like"current_selection_csv"/"current_selection_excel") so that the changes are visible in the interface.apps/web/app/(app)/environments/[environmentId]/surveys/[surveyId]/components/CustomFilter.tsx (3)
393-393: Code styling change looks good.The class attributes reordering doesn't affect functionality while maintaining proper styling for the download button.
419-419: Terminology improvement looks good.Changing from "current selection" to "filtered responses" provides clearer context to users about what they're downloading, aligning with the PR objective of modifying the button label.
426-427: Consistent terminology update looks good.This change ensures consistency with the CSV option, using "filtered responses" rather than "current selection" for the Excel download option as well.
✅ Generated 3 tests - 3 passed (a8f8ef3) View tests ↗Test Summary
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/lib/messages/fr-FR.json (1)
1748-1750: Verify Casing for Filtered Responses LabelsThe new entries
"filtered_responses_csv": "Réponses filtrées (CSV)""filtered_responses_excel": "Réponses filtrées (Excel)"replace the previous
"current_selection_csv"and"current_selection_excel"keys. Since the PR objective specifically mentions that the word "responses" in the download responses button label should be displayed in lowercase, please verify whether the French version should use a lowercase initial letter (e.g."réponses filtrées (CSV)") or if the current capitalization conforms to the French style guidelines for UI labels.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
packages/lib/messages/de-DE.json(2 hunks)packages/lib/messages/en-US.json(2 hunks)packages/lib/messages/fr-FR.json(2 hunks)packages/lib/messages/pt-BR.json(2 hunks)packages/lib/messages/pt-PT.json(2 hunks)packages/lib/messages/zh-Hant-TW.json(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (4)
- packages/lib/messages/pt-PT.json
- packages/lib/messages/en-US.json
- packages/lib/messages/pt-BR.json
- packages/lib/messages/zh-Hant-TW.json
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: Run E2E Tests / Run E2E Tests
- GitHub Check: Run Linters / Linters
- GitHub Check: Build Formbricks-web / Build Formbricks-web
- GitHub Check: Analyze (javascript)
- GitHub Check: Run Unit Tests / Unit Tests
- GitHub Check: Validate Docker Build
- GitHub Check: SonarQube
🔇 Additional comments (3)
packages/lib/messages/de-DE.json (2)
780-787: Addition of API Key Access Control translation.
The new"access_control": "Zugriffskontrolle"key has been added under the"api_keys"section in the project object. This update aligns with similar changes across other localization files, ensuring consistency in the API key management interface.
1748-1750: Updated download button labels for filtered responses.
The new localization keys"filtered_responses_csv": "Gefilterte Antworten (CSV)"and"filtered_responses_excel": "Gefilterte Antworten (Excel)"correctly replace the legacy labels by providing an updated, unified text that meets the PR objective. Although the word “responses” is required to be lowercase in the English UI, please note that German nouns are customarily capitalized. Verify that this is acceptable for the German UI design or if an exception is needed.packages/lib/messages/fr-FR.json (1)
780-788: Added Localization Key for API KeysThe new key
"access_control": "Contrôle d'accès"has been introduced in the API keys section. The addition is consistent with similar changes in other locale files. Please confirm that this translation follows the overall style and terminology guidelines for your project.
|
Co-authored-by: Dhruwang <dhruwangjariwala18@gmail.com>
2 participants
What does this PR do?
download responses button label and made responses selected lowercase
Fixes #(issue)
How should this be tested?
Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated
Summary by CodeRabbit