fix: adds no-cache header when debug mode is ON

[pandeymangg]

What does this PR do?

fixes the no-cache header during debug mode

How should this be tested?

• Enter debug mode in formbricks demo app and see the cache-control header in environment request

Checklist

Required

• Filled out the "How to test" section in this PR
• Read How we Code at Formbricks
• Self-reviewed my own code
• Commented on my code in hard-to-understand bits
• Ran pnpm build
• Checked for warnings, there are none
• Removed all console.logs
• Merged the latest changes from main onto my branch with git pull origin main
• My changes don't cause any responsiveness issues
• First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

• If a UI change was made: Added a screen recording or screenshots to this PR
• Updated the Formbricks Docs if changes were necessary

Summary by CodeRabbit

• Bug Fixes
  • Corrected the placement of the cache-control header to ensure it is properly included within HTTP headers during debug mode, improving request reliability.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
formbricks-cloud	⬜️ Ignored (Inspect)	Visit Preview		Apr 17, 2025 8:50am

[use-tusk]

⏩ No test execution environment matched (043965a) View output ↗

View output in GitHub ↗

View check history

Commit	Status	Output	Tests	Passed	Failed	Error
f321707	⏩ No test execution environment matched	Output
043965a	⏩ No test execution environment matched	Output

[github-actions]

Thank you for following the naming conventions for pull request titles! 🙏

[coderabbitai]

Walkthrough

The changes update the way the "Cache-Control": "no-cache" HTTP header is conditionally added in two API utility files. Previously, the "Cache-Control" header was incorrectly placed at the top level of the fetch options object, outside of the headers dictionary. The revisions move this conditional logic inside the headers object, ensuring that "Cache-Control" is only included within the headers when the isDebug flag is true. No other logic or exported/public entity declarations are affected by these changes.

Possibly related PRs

• fix: Add Cache-Control to allowed CORS headers #5252: Adds "Cache-Control" to the allowed CORS headers on the server side, related to handling the same header but in a different layer of the codebase.

Suggested labels

bug

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f321707 and 043965a.

📒 Files selected for processing (2)

• packages/js-core/src/lib/common/tests/api.test.ts (1 hunks)
• packages/react-native/src/lib/common/tests/api.test.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Analyze (javascript)

🔇 Additional comments (2)

packages/react-native/src/lib/common/tests/api.test.ts (1)

167-167: Correct placement of Cache-Control header

The Cache-Control header is now properly placed inside the headers object, which aligns with the Fetch API specification. This change correctly tests that the no-cache header is added when debug mode is enabled.

packages/js-core/src/lib/common/tests/api.test.ts (1)

167-167: Correct placement of Cache-Control header

The Cache-Control header is now properly placed inside the headers object, consistent with the change in the React Native package. This ensures all implementations follow the Fetch API specification correctly and validates that no-cache headers are added in debug mode.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[Dhruwang]

LGTM 🚀

[sonarqubecloud]

Quality Gate passed for 'formbricks'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud