chore: move js sdk and demo app to its own repository#5668
Conversation
|
Thank you for following the naming conventions for pull request titles! 🙏 |
|
""" WalkthroughThis change removes all code, configuration, and dependencies related to the Formbricks JavaScript SDK and its demo application from the repository. The entire Possibly related PRs
Suggested labels
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (7)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
turbo.json (1)
176-176: Document & ensure default forDISABLE_USER_MANAGEMENT
You've addedDISABLE_USER_MANAGEMENTto the environment. Update.env.exampleand README/docs to reflect this new variable and its default of1, and confirm CI/CD pipelines include it.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (6)
apps/demo/public/favicon.icois excluded by!**/*.icoapps/demo/public/fb-setup.pngis excluded by!**/*.pngapps/demo/public/next.svgis excluded by!**/*.svgapps/demo/public/thirteen.svgis excluded by!**/*.svgapps/demo/public/vercel.svgis excluded by!**/*.svgpnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (47)
.env.example(1 hunks)apps/demo/.env.example(0 hunks)apps/demo/.eslintrc.js(0 hunks)apps/demo/.gitignore(0 hunks)apps/demo/components/layout-app.tsx(0 hunks)apps/demo/components/sidebar.tsx(0 hunks)apps/demo/globals.css(0 hunks)apps/demo/lib/utils.ts(0 hunks)apps/demo/next-env.d.ts(0 hunks)apps/demo/next.config.mjs(0 hunks)apps/demo/package.json(0 hunks)apps/demo/pages/_app.tsx(0 hunks)apps/demo/pages/_document.tsx(0 hunks)apps/demo/pages/index.tsx(0 hunks)apps/demo/postcss.config.js(0 hunks)apps/demo/tsconfig.json(0 hunks)apps/web/app/(app)/(onboarding)/organizations/[organizationId]/landing/components/landing-sidebar.tsx(0 hunks)apps/web/app/(app)/components/FormbricksClient.test.tsx(0 hunks)apps/web/app/(app)/components/FormbricksClient.tsx(0 hunks)apps/web/app/(app)/environments/[environmentId]/components/MainNavigation.tsx(1 hunks)apps/web/app/(app)/environments/[environmentId]/settings/(account)/profile/components/DeleteAccount.tsx(0 hunks)apps/web/app/(app)/layout.test.tsx(0 hunks)apps/web/app/(app)/layout.tsx(1 hunks)apps/web/app/lib/formbricks.ts(0 hunks)apps/web/lib/constants.ts(0 hunks)apps/web/lib/env.ts(0 hunks)apps/web/modules/account/components/DeleteAccountModal/index.tsx(0 hunks)apps/web/modules/setup/organization/create/components/removed-from-organization.tsx(0 hunks)apps/web/modules/survey/components/question-form-input/index.test.tsx(0 hunks)apps/web/modules/survey/editor/components/create-new-action-tab.test.tsx(0 hunks)apps/web/modules/ui/components/client-logout/index.tsx(0 hunks)apps/web/modules/ui/components/environmentId-base-layout/index.test.tsx(0 hunks)apps/web/modules/ui/components/environmentId-base-layout/index.tsx(1 hunks)apps/web/package.json(0 hunks)docker/docker-compose.yml(0 hunks)package.json(0 hunks)packages/js/.eslintrc.cjs(0 hunks)packages/js/.gitignore(0 hunks)packages/js/LICENSE(0 hunks)packages/js/README.md(0 hunks)packages/js/package.json(0 hunks)packages/js/src/index.ts(0 hunks)packages/js/src/lib/load-formbricks.ts(0 hunks)packages/js/src/vite-env.d.ts(0 hunks)packages/js/tsconfig.json(0 hunks)packages/js/vite.config.ts(0 hunks)turbo.json(2 hunks)
💤 Files with no reviewable changes (42)
- apps/web/app/(app)/layout.test.tsx
- apps/web/modules/survey/editor/components/create-new-action-tab.test.tsx
- apps/web/modules/ui/components/environmentId-base-layout/index.test.tsx
- packages/js/README.md
- apps/demo/lib/utils.ts
- package.json
- apps/web/lib/constants.ts
- apps/web/modules/survey/components/question-form-input/index.test.tsx
- apps/web/app/(app)/(onboarding)/organizations/[organizationId]/landing/components/landing-sidebar.tsx
- apps/demo/postcss.config.js
- apps/web/app/(app)/environments/[environmentId]/settings/(account)/profile/components/DeleteAccount.tsx
- packages/js/src/vite-env.d.ts
- docker/docker-compose.yml
- apps/demo/.eslintrc.js
- apps/web/modules/account/components/DeleteAccountModal/index.tsx
- apps/demo/.env.example
- packages/js/tsconfig.json
- packages/js/.eslintrc.cjs
- packages/js/.gitignore
- apps/web/app/lib/formbricks.ts
- apps/demo/next.config.mjs
- apps/demo/next-env.d.ts
- packages/js/vite.config.ts
- apps/web/package.json
- apps/demo/globals.css
- apps/demo/components/sidebar.tsx
- apps/demo/package.json
- packages/js/src/index.ts
- apps/demo/pages/_document.tsx
- apps/web/app/(app)/components/FormbricksClient.tsx
- apps/web/modules/ui/components/client-logout/index.tsx
- apps/demo/pages/_app.tsx
- apps/web/modules/setup/organization/create/components/removed-from-organization.tsx
- apps/web/lib/env.ts
- apps/web/app/(app)/components/FormbricksClient.test.tsx
- apps/demo/pages/index.tsx
- packages/js/LICENSE
- apps/demo/tsconfig.json
- apps/demo/.gitignore
- apps/demo/components/layout-app.tsx
- packages/js/package.json
- packages/js/src/lib/load-formbricks.ts
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: Run Unit Tests / Unit Tests
- GitHub Check: Run E2E Tests / Run E2E Tests
- GitHub Check: Build Formbricks-web / Build Formbricks-web
- GitHub Check: SonarQube
- GitHub Check: Validate Docker Build
- GitHub Check: Analyze (javascript)
🔇 Additional comments (6)
.env.example (1)
223-223: Updated default value for user management settingThe change adds a default value of
1for theDISABLE_USER_MANAGEMENTvariable, which sets the system to disable user management from the UI by default. This aligns with the overall goal of streamlining the repository and removing unnecessary components.apps/web/app/(app)/environments/[environmentId]/components/MainNavigation.tsx (1)
267-267: LGTM: Minor CSS class reorderingThe change simply reorders CSS classes in the toggle sidebar button without affecting functionality.
apps/web/modules/ui/components/environmentId-base-layout/index.tsx (1)
3-3: Removed Formbricks constants importsThe import statement has been updated to only include
IS_POSTHOG_CONFIGURED, removing Formbricks-related constants. This is consistent with the PR objective to move the JS SDK and demo app to its own repository.apps/web/app/(app)/layout.tsx (1)
2-2: Removed Formbricks constants importsThe import statement has been updated to only include PostHog-related constants, removing Formbricks-related constants. This is consistent with the PR objective to move the JS SDK and demo app to its own repository.
turbo.json (2)
64-64: Review coverage dependencies forweb#test:coverage
Similarly,web#test:coverageonly depends on logger build. Ensure coverage is measured on compiled code—add@formbricks/web#buildas a prerequisite if necessary.
61-61:Details
❓ Verification inconclusive
Review test dependencies for
web#test
Theweb#testtask now only depends on@formbricks/logger#build. Verify that it still builds and tests the web application itself—consider adding@formbricks/web#build(or other core build tasks) to itsdependsOnto avoid running tests against stale code.Run:
🏁 Script executed:
#!/bin/bash # Check the definition of web#test in turbo.json rg -n '"@formbricks/web#test"' -C2 turbo.jsonLength of output: 179
🏁 Script executed:
#!/bin/bash # Verify that @formbricks/web#build task exists in turbo.json rg -n '"@formbricks/web#build"' -C2 turbo.jsonLength of output: 48
Verify web build dependency for
web#test
We didn’t find a@formbricks/web#buildtask in turbo.json, so it’s unclear whether the web code is being rebuilt before tests run. Please confirm that yourweb#teststep actually compiles the latest web code, and if not, add the appropriate@formbricks/web#build(or equivalent) to itsdependsOn.• File: turbo.json
• Section:"@formbricks/web#test": { "dependsOn": ["@formbricks/logger#build"] }
|
1 participant
With this PR the js SDK and the demo app for the JS SDK is now moved to its own repository formbricks/js.
This pull request removes the
apps/demodirectory and its associated files, effectively deprecating the demo application. Additionally, it updates the.env.examplefile to remove unused environment variables and provide a default value forDISABLE_USER_MANAGEMENT.Removal of the demo application:
apps/demodirectory, including configuration files (.env.example,.eslintrc.js,.gitignore,next.config.mjs,package.json,postcss.config.js), global styles (globals.css), utility functions (lib/utils.ts), and all components and pages (layout-app.tsx,sidebar.tsx,_app.tsx,_document.tsx,index.tsx). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Updates to
.env.example:FORMBRICKS_API_HOSTandFORMBRICKS_ENVIRONMENT_IDvariables.1) for theDISABLE_USER_MANAGEMENTvariable to disable user management from the UI by default.Summary by CodeRabbit