Skip to content

fix: alignment issue in file upload#5828

Merged
mattinannt merged 2 commits intoformbricks:mainfrom
abhiifour:issue-fileUpload
May 29, 2025
Merged

fix: alignment issue in file upload#5828
mattinannt merged 2 commits intoformbricks:mainfrom
abhiifour:issue-fileUpload

Conversation

@abhiifour
Copy link
Copy Markdown
Contributor

@abhiifour abhiifour commented May 16, 2025

What does this PR do?

This pr deals with the changes made to fix the alignment issue in the file upload survey forms .

  • previously it was aligned to the left .

image

  • now aligned to the center .

Screenshot from 2025-05-16 19-11-05

Fixes #5746

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

Summary by CodeRabbit

  • Style
    • Improved alignment of elements within the file input component for a more visually centered appearance.

@github-actions github-actions bot added the bug Something isn't working label May 16, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 16, 2025

Thank you for following the naming conventions for pull request titles! 🙏

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented May 16, 2025

Walkthrough

The change updates the FileInput component by replacing the fb-items-left class with the fb-items-center class on the outermost <div> container. This adjustment changes the flexbox alignment of the container’s children from aligning items to the start of the cross axis to centering them. No other logic, event handling, or exports are modified.

Assessment against linked issues

Objective Addressed Explanation
Fix alignment issue in file upload question (#5746)

Suggested reviewers

  • gupta-piyush19
  • Dhruwang

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/surveys/src/components/general/file-input.tsx

Oops! Something went wrong! :(

ESLint: 8.57.0

ESLint couldn't find the plugin "eslint-plugin-turbo".

(The package "eslint-plugin-turbo" was not found when loaded as a Node module from the directory "/packages/surveys".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-turbo@latest --save-dev

The plugin "eslint-plugin-turbo" was referenced from the config file in "packages/surveys/.eslintrc.cjs » @formbricks/eslint-config/legacy-react.js » eslint-config-turbo".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.


Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ec0b775 and 1333bb6.

📒 Files selected for processing (1)
  • packages/surveys/src/components/general/file-input.tsx (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/surveys/src/components/general/file-input.tsx
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 022d33d and ec0b775.

📒 Files selected for processing (1)
  • packages/surveys/src/components/general/file-input.tsx (1 hunks)

@jobenjada
Copy link
Copy Markdown
Member

hey! please record a video where you reproduced the issue and with your fix, I cannot reproduce it so I cant validate that your PR doesnt break something that's working :)

@abhiifour
Copy link
Copy Markdown
Contributor Author

Screencast.from.2025-05-17.13-03-46.webm
  • i am running a next app on localhost:3001 for survey testing . which i was running on incognito .
  • formsbrick running on port 3000.

@jobenjada please check .

@jobenjada jobenjada enabled auto-merge May 17, 2025 07:57
@jobenjada jobenjada self-requested a review May 17, 2025 07:57
@jobenjada jobenjada requested a review from Dhruwang May 17, 2025 08:05
Copy link
Copy Markdown
Member

@Dhruwang Dhruwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@mattinannt mattinannt disabled auto-merge May 29, 2025 14:40
@mattinannt mattinannt merged commit ad0c342 into formbricks:main May 29, 2025
9 of 13 checks passed
glade-at-gigwell pushed a commit to gigwell/formbricks that referenced this pull request Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alignment issue in file upload question

4 participants