Skip to content

fix: consistent enabled/disabled wording for connector status#7897

Merged
Dhruwang merged 4 commits into
epic/v5from
fix/eng-769-consistent-connector-status-wording
Apr 28, 2026
Merged

fix: consistent enabled/disabled wording for connector status#7897
Dhruwang merged 4 commits into
epic/v5from
fix/eng-769-consistent-connector-status-wording

Conversation

@Dhruwang
Copy link
Copy Markdown
Member

@Dhruwang Dhruwang commented Apr 28, 2026

Summary

  • Connector status badges now show Enabled / Disabled instead of "In Progress" / "Paused", matching the dropdown action labels ("Enable" / "Disable")
  • Added common.enabled and common.disabled locale keys across all 15 locales
Screenshot 2026-04-28 at 12 38 48 PM Screenshot 2026-04-28 at 12 38 55 PM

Fixes https://linear.app/formbricks/issue/ENG-769/inconsistent-wording-in-input-sources-v5

Test plan

  • Verify connector status badge shows "Enabled" when active and "Disabled" when paused
  • Verify dropdown still shows "Disable" / "Enable" actions
  • Verify error status still shows "Error"

Resolves ENG-769

🤖 Generated with Claude Code

The dropdown actions say "Enable"/"Disable" but the status badges showed
"In Progress"/"Paused". Now both use "Enabled"/"Disabled" for consistency.

Resolves ENG-769

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 28, 2026

Walkthrough

The change updates the localization strategy for connector status badge labels in the connector table row component. Translation keys for "active" and "paused" statuses were switched from workspace-specific keys (workspace.unify.status_active and workspace.unify.status_paused) to shared common keys (common.enabled and common.disabled). Other status handling mechanisms remain unchanged.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: standardizing connector status wording to use 'enabled/disabled' for consistency.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description provides a clear summary of changes, includes visual screenshots, references the resolved issue, and outlines a test plan with specific verification steps.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Dhruwang Dhruwang requested a review from jobenjada April 28, 2026 07:11
@jobenjada
Copy link
Copy Markdown
Member

@Dhruwang this works! For context, I have tweaked the state to be dependent on the Connector type (Formbricks Surveys have "Live Sync" while CSV has "Ready") but we can simplify this, merge this PR and and remove this tweak from the PR which will throw a merge conflict

Dhruwang and others added 2 commits April 28, 2026 13:47
- Add optional chaining for organization.billing in response pipeline
- Add missing feedbackRecordDirectoryId to Chart seed data

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…oute

Pipeline errors (snapshot loading or dispatch) should not prevent the
201 response from being returned. Dispatch pipeline events without
awaiting so the response is returned immediately.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@sonarqubecloud
Copy link
Copy Markdown

@Dhruwang Dhruwang merged commit a862b73 into epic/v5 Apr 28, 2026
13 checks passed
@Dhruwang Dhruwang deleted the fix/eng-769-consistent-connector-status-wording branch April 28, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants