Skip to content

FIO-9329: fix issue where validateWhenHidden now validates hidden and conditionally hidden components#191

Merged
johnformio merged 1 commit intomasterfrom
FIO-9329
Nov 18, 2024
Merged

FIO-9329: fix issue where validateWhenHidden now validates hidden and conditionally hidden components#191
johnformio merged 1 commit intomasterfrom
FIO-9329

Conversation

@brendanbond
Copy link
Copy Markdown
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-9329

Description

What changed?

Changes to when we validate based on visibility, namely that the shouldSkipValidation function checks for the validateWhenHidden flag AND general visibility (so both conditionally hidden components and intentionally hidden ones).

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

Tests here are passing, automated tests were included in @formio/js

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@johnformio johnformio merged commit 770d1df into master Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants