Skip to content

FIO-10263: rely on instance level evaluation context to provide us with submission variable#264

Merged
lane-formio merged 1 commit intomasterfrom
FIO-10263
Jun 10, 2025
Merged

FIO-10263: rely on instance level evaluation context to provide us with submission variable#264
lane-formio merged 1 commit intomasterfrom
FIO-10263

Conversation

@brendanbond
Copy link
Copy Markdown
Contributor

Link to Jira Ticket

https://formio.atlassian.net/browse/FIO-10263

Description

When we validate on the renderer, we don't provide a submission value into the context. This is a problem, because evaluation contexts need the submission variable as part of the stuff we provide the form user. However, when I made updates to the Evaluator, I accidentally added a submission "overwrite" to the evaluation context instead of just relying on what we get from the instance itself. This PR fixes the error.

Breaking Changes / Backwards Compatibility

n/a

Dependencies

n/a

How has this PR been tested?

Tests for this really belong in formio.js - I will add some and link them here.

Checklist:

  • I have completed the above PR template
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • My changes include tests that prove my fix is effective (or that my feature works as intended)
  • New and existing unit/integration tests pass locally with my changes
  • Any dependent changes have corresponding PRs that are listed above

@lane-formio lane-formio merged commit bc139e6 into master Jun 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants