v2.38.2 - File component not showing errors#650
Merged
travist merged 1 commit intoformio:2.xfrom Oct 2, 2019
Merged
Conversation
CatBakun
changed the title
Member
|
Thanks @CatBakun! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ngFormio Version: 2.38.2
Reproduce:
1 - Render a form with a required file component.
2 - Add a file
3 - Remove the file
Expected result: The required file component shows a validation error.
Actual result: The required file component never shows error messages.
This was happening for 2 things:
1 - The file component value is
[""]after removing all images.2 - The ngModel for the file component never gets dirty state.