Skip to content

feat: add graphical capabilities to core items and widgets#410

Merged
forntoh merged 2 commits into
feat/graphical-displayfrom
gd/05-item-graphical-capabilities
Apr 24, 2026
Merged

feat: add graphical capabilities to core items and widgets#410
forntoh merged 2 commits into
feat/graphical-displayfrom
gd/05-item-graphical-capabilities

Conversation

@forntoh
Copy link
Copy Markdown
Owner

@forntoh forntoh commented Apr 24, 2026

Summary

  • Add GraphicalMenuItem capability support across core items and widget-backed items, including graphical value-width measurement, toggle/list indicators, and a BasicItem implementation for ITEM_BASIC/ITEM_LABEL.
  • Improve widget/item drawing safety for graphical rendering by hardening buffer handling (ITEM_DRAW_BUFFER_SIZE growth, null-safe bool widget formatting) and exposing optional GraphicalValueSelectionRenderer extension hooks.
  • Add unit coverage for new item capabilities in test/ItemValue.cpp and document the new graphical item capability model in docs/source/overview/rendering/graphical-display.rst.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 24, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: f5470c3b-bbfb-4ace-9d4f-23fd04053944

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • ✅ Review completed - (🔄 Check again to review again)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch gd/05-item-graphical-capabilities

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@forntoh forntoh merged commit 2677d2e into feat/graphical-display Apr 24, 2026
13 of 17 checks passed
@forntoh forntoh deleted the gd/05-item-graphical-capabilities branch April 24, 2026 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant