Centralize graphical frame lifecycle

[forntoh]

Summary

• move graphical frame finalization to LcdMenu entry points for setScreen, handled process calls, show, and refresh
• stop MenuScreen from ending frames directly during draw
• update graphical viewport context before item command handling
• adjust lifecycle tests for centralized ownership

Checks

• git diff --check
• pio run -e esp32

Notes

• intentionally skips low-value timeout debounce drift and doc-comment-only drift
• intentionally skips broad viewport structural churn without clear behavior value
• only src/LcdMenu.cpp, src/MenuScreen.cpp, and test/LcdMenu.cpp are included

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: ee87f599-156f-4860-bdb4-1606c1df2b6a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch gd/12-core-lifecycle-bundle

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}