Skip to content

Complete graphical renderer parity#419

Merged
forntoh merged 2 commits into
feat/graphical-displayfrom
gd/13-renderer-bundle
May 26, 2026
Merged

Complete graphical renderer parity#419
forntoh merged 2 commits into
feat/graphical-displayfrom
gd/13-renderer-bundle

Conversation

@forntoh
Copy link
Copy Markdown
Owner

@forntoh forntoh commented May 26, 2026

Summary

  • port remaining graphical renderer drawItem text/value windowing behavior
  • improve cursor placeholder, blinker, toggle, list/submenu indicator, row-height, and scrollbar handling
  • update focused GraphicalDisplayRenderer tests, including review-fix coverage for short values

Review fixes

  • avoid reserving one-third of the row for short/empty values when valueAreaWidth is unset
  • align draw color capture test stub with its expanded capture buffer

Checks

  • git diff --check
  • clang-format --dry-run --Werror src/renderer/GraphicalDisplayRenderer.cpp src/renderer/GraphicalDisplayRenderer.h test/GraphicalDisplayRenderer.cpp
  • pio run -e esp32

Notes

  • pio test -e esp32 is still blocked locally by missing ArduinoUnitTests.h / Godmode.h in the current repo test harness
  • intentionally skipped snapshot deletion of test/GraphicalDisplayRenderer.cpp because focused coverage is valuable
  • only GraphicalDisplayRenderer files and test/GraphicalDisplayRenderer.cpp are included

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 26, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 70106a52-adc4-4614-bb3b-e21907e9115f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch gd/13-renderer-bundle

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@forntoh forntoh merged commit 91f40a1 into feat/graphical-display May 26, 2026
12 of 14 checks passed
@forntoh forntoh deleted the gd/13-renderer-bundle branch May 26, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant