Skip to content

Align input graphical selection docs#420

Merged
forntoh merged 1 commit into
feat/graphical-displayfrom
gd/14-input-docs-bundle
May 26, 2026
Merged

Align input graphical selection docs#420
forntoh merged 1 commit into
feat/graphical-displayfrom
gd/14-input-docs-bundle

Conversation

@forntoh
Copy link
Copy Markdown
Owner

@forntoh forntoh commented May 26, 2026

Summary

  • always clear graphical value selection after input item rendering
  • remove stale implementation-specific input graphical docs/comments
  • strengthen LcdMenu input graphical selection coverage to verify selection set/clear behavior

Checks

  • git diff --check
  • clang-format --dry-run --Werror src/ItemInput.h src/ItemInputCharset.h test/LcdMenu.cpp
  • pio run -e esp32
  • make html (from docs/; succeeded with existing unrelated warnings)

Notes

  • focused pio test path remains blocked locally by missing ArduinoUnitTests.h / Godmode.h in the current PlatformIO test harness
  • intentionally skipped snapshot deletions in test/ItemValue.cpp as low-value/unrelated to this bundle
  • only scoped input headers, item docs pages, and test/LcdMenu.cpp are included

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 26, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 938ce819-6987-4168-90df-286f8aa398e8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch gd/14-input-docs-bundle

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@forntoh forntoh merged commit da36936 into feat/graphical-display May 26, 2026
13 of 17 checks passed
@forntoh forntoh deleted the gd/14-input-docs-bundle branch May 26, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant