Skip to content

Fix input item first character crash#422

Merged
forntoh merged 1 commit into
feat/graphical-displayfrom
fix/input-item-first-character-crash
May 27, 2026
Merged

Fix input item first character crash#422
forntoh merged 1 commit into
feat/graphical-displayfrom
fix/input-item-first-character-crash

Conversation

@forntoh
Copy link
Copy Markdown
Owner

@forntoh forntoh commented May 27, 2026

Summary

  • track whether ItemInput owns its value buffer before freeing it
  • make default-empty inputs use owned writable storage
  • clone external values before mutating them in input and charset edit paths
  • add regression coverage for default-empty, static, and stack-backed input values

Verification

  • pio run -e esp32 passed
  • pio test -e esp32 fails before running tests due missing known harness headers: ArduinoUnitTests.h and Godmode.h
  • pio run -e uno fails due existing program/RAM size overflow for the current app build

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 27, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: a7b43713-a21c-4b4b-bda6-d12db0a16a5a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/input-item-first-character-crash

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@forntoh forntoh merged commit 21ee38a into feat/graphical-display May 27, 2026
13 of 17 checks passed
@forntoh forntoh deleted the fix/input-item-first-character-crash branch May 27, 2026 08:04
forntoh added a commit that referenced this pull request May 28, 2026
## Preview

![Graphical display
demo](https://raw.githubusercontent.com/forntoh/LcdMenu/feat/graphical-display/docs/source/images/home-graphical-display.gif)

## Summary
- add graphical display rendering through `GraphicalDisplayRenderer` and
U8g2-backed display adapters
- add renderer lifecycle/context extensions, graphical item
capabilities, fonts, glyphs, indicators, scrollbars, toggles, and
value-selection rendering
- add graphical examples for SSD1306 and ST7920 displays
- document graphical display setup, item behavior, and README/homepage
demos
- fix input item value ownership so default-empty inputs do not crash on
first typed character

## Verification
- feature branch PR checks passed across the staged graphical-display
PRs
- final branch includes docs/media updates and input crash fix from PRs
#421 and #422

Closes #382
Resolves #210
Resolves #200
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant