Rename inline comment views to "PHUIDiff" and give them a base class

Summary:
Ref T2009. These classes are "Differential" now, but are used elsewhere in diff infrastructure (e.g., Diffusion).

  - Rename them to "PHUIDiff".
  - Move them to "src/infrastructure/".
  - Give them a base class.

Test Plan: Interacted with inlines in unified and side-by-side views.

Reviewers: btrahan

Subscribers: epriestley

Maniphest Tasks: T2009

Differential Revision: https://secure.phabricator.com/D11996

Author: epriestley

src/__phutil_library_map__.php

@@ -375,10 +375,8 @@
     'DifferentialHunkTestCase' => 'applications/differential/storage/__tests__/DifferentialHunkTestCase.php',
     'DifferentialInlineComment' => 'applications/differential/storage/DifferentialInlineComment.php',
     'DifferentialInlineCommentEditController' => 'applications/differential/controller/DifferentialInlineCommentEditController.php',
-    'DifferentialInlineCommentEditView' => 'applications/differential/view/DifferentialInlineCommentEditView.php',
     'DifferentialInlineCommentPreviewController' => 'applications/differential/controller/DifferentialInlineCommentPreviewController.php',
     'DifferentialInlineCommentQuery' => 'applications/differential/query/DifferentialInlineCommentQuery.php',
-    'DifferentialInlineCommentView' => 'applications/differential/view/DifferentialInlineCommentView.php',
     'DifferentialJIRAIssuesField' => 'applications/differential/customfield/DifferentialJIRAIssuesField.php',
     'DifferentialLandingActionMenuEventListener' => 'applications/differential/landing/DifferentialLandingActionMenuEventListener.php',
     'DifferentialLandingStrategy' => 'applications/differential/landing/DifferentialLandingStrategy.php',
@@ -1138,6 +1136,9 @@
     'PHUIColorPalletteExample' => 'applications/uiexample/examples/PHUIColorPalletteExample.php',
     'PHUICrumbView' => 'view/phui/PHUICrumbView.php',
     'PHUICrumbsView' => 'view/phui/PHUICrumbsView.php',
+    'PHUIDiffInlineCommentDetailView' => 'infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php',
+    'PHUIDiffInlineCommentEditView' => 'infrastructure/diff/view/PHUIDiffInlineCommentEditView.php',
+    'PHUIDiffInlineCommentView' => 'infrastructure/diff/view/PHUIDiffInlineCommentView.php',
     'PHUIDocumentExample' => 'applications/uiexample/examples/PHUIDocumentExample.php',
     'PHUIDocumentView' => 'view/phui/PHUIDocumentView.php',
     'PHUIFeedStoryExample' => 'applications/uiexample/examples/PHUIFeedStoryExample.php',
@@ -3518,10 +3519,8 @@
     'DifferentialHunkTestCase' => 'ArcanistPhutilTestCase',
     'DifferentialInlineComment' => 'PhabricatorInlineCommentInterface',
     'DifferentialInlineCommentEditController' => 'PhabricatorInlineCommentController',
-    'DifferentialInlineCommentEditView' => 'AphrontView',
     'DifferentialInlineCommentPreviewController' => 'PhabricatorInlineCommentPreviewController',
     'DifferentialInlineCommentQuery' => 'PhabricatorOffsetPagedQuery',
-    'DifferentialInlineCommentView' => 'AphrontView',
     'DifferentialJIRAIssuesField' => 'DifferentialStoredCustomField',
     'DifferentialLandingActionMenuEventListener' => 'PhabricatorEventListener',
     'DifferentialLegacyHunk' => 'DifferentialHunk',
@@ -4366,6 +4365,9 @@
     'PHUIColorPalletteExample' => 'PhabricatorUIExample',
     'PHUICrumbView' => 'AphrontView',
     'PHUICrumbsView' => 'AphrontView',
+    'PHUIDiffInlineCommentDetailView' => 'PHUIDiffInlineCommentView',
+    'PHUIDiffInlineCommentEditView' => 'PHUIDiffInlineCommentView',
+    'PHUIDiffInlineCommentView' => 'AphrontView',
     'PHUIDocumentExample' => 'PhabricatorUIExample',
     'PHUIDocumentView' => 'AphrontTagView',
     'PHUIFeedStoryExample' => 'PhabricatorUIExample',

src/applications/differential/render/DifferentialChangesetHTMLRenderer.php

@@ -430,7 +430,7 @@ protected function buildInlineComment(
             && $this->getShowEditAndReplyLinks();
     $allow_reply = (bool)$user && $this->getShowEditAndReplyLinks();
 
-    return id(new DifferentialInlineCommentView())
+    return id(new PHUIDiffInlineCommentDetailView())
       ->setInlineComment($comment)
       ->setOnRight($on_right)
       ->setHandles($this->getHandles())

src/applications/diffusion/controller/DiffusionBrowseFileController.php

@@ -845,7 +845,7 @@ private function renderInlines(
 
     $rows = array();
     foreach ($inlines as $inline) {
-      $inline_view = id(new DifferentialInlineCommentView())
+      $inline_view = id(new PHUIDiffInlineCommentDetailView())
         ->setMarkupEngine($engine)
         ->setInlineComment($inline)
         ->render();

src/infrastructure/diff/PhabricatorInlineCommentController.php

@@ -196,7 +196,7 @@ private function buildEditDialog() {
     $request = $this->getRequest();
     $user = $request->getUser();
 
-    $edit_dialog = id(new DifferentialInlineCommentEditView())
+    $edit_dialog = id(new PHUIDiffInlineCommentEditView())
       ->setUser($user)
       ->setSubmitURI($request->getRequestURI())
       ->setOnRight($this->getIsOnRight())
@@ -233,7 +233,7 @@ private function buildRenderedCommentResponse(
 
     $handles = $this->loadViewerHandles($phids);
 
-    $view = id(new DifferentialInlineCommentView())
+    $view = id(new PHUIDiffInlineCommentDetailView())
       ->setInlineComment($inline)
       ->setOnRight($on_right)
       ->setBuildScaffolding(true)

src/infrastructure/diff/PhabricatorInlineCommentPreviewController.php

@@ -26,7 +26,7 @@ public function processRequest() {
 
     $views = array();
     foreach ($inlines as $inline) {
-      $view = new DifferentialInlineCommentView();
+      $view = new PHUIDiffInlineCommentDetailView();
       $view->setInlineComment($inline);
       $view->setMarkupEngine($engine);
       $view->setHandles($handles);

…l/view/DifferentialInlineCommentView.php …view/PHUIDiffInlineCommentDetailView.phpsrc/applications/differential/view/DifferentialInlineCommentView.php renamed to src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php src/applications/differential/view/DifferentialInlineCommentView.php renamed to src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

@@ -1,6 +1,7 @@
 <?php
 
-final class DifferentialInlineCommentView extends AphrontView {
+final class PHUIDiffInlineCommentDetailView
+  extends PHUIDiffInlineCommentView {
 
   private $inlineComment;
   private $onRight;

…ew/DifferentialInlineCommentEditView.php …f/view/PHUIDiffInlineCommentEditView.phpsrc/applications/differential/view/DifferentialInlineCommentEditView.php renamed to src/infrastructure/diff/view/PHUIDiffInlineCommentEditView.php src/applications/differential/view/DifferentialInlineCommentEditView.php renamed to src/infrastructure/diff/view/PHUIDiffInlineCommentEditView.php

@@ -1,6 +1,7 @@
 <?php
 
-final class DifferentialInlineCommentEditView extends AphrontView {
+final class PHUIDiffInlineCommentEditView
+  extends PHUIDiffInlineCommentView {
 
   private $inputs = array();
   private $uri;

src/infrastructure/diff/view/PHUIDiffInlineCommentView.php

@@ -0,0 +1,3 @@
+<?php
+
+abstract class PHUIDiffInlineCommentView extends AphrontView {}