Glossary generator with apa lookup#595
Conversation
✅ Spell Check PassedNo spelling issues found in this PR! 🎉 |
|
👍 All image files/references (if any) are in webp format, in line with our policy. |
✅ Spell Check PassedNo spelling issues found in this PR! 🎉 |
There was a problem hiding this comment.
Pull request overview
Adds an APA-reference lookup workflow and updates glossary generation to use it when producing glossary entry files.
Changes:
- Added
content/glossary/apa_lookup.jsonas a citation-key → APA-formatted reference lookup. - Refactored
content/glossary/_create_glossaries.pyto pull glossary data from a Google Sheets CSV export and format references via the APA lookup. - Added a Node.js utility (
bibtex_to_apa/) and CI workflow steps to generate/update the APA lookup during data processing.
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| content/glossary/apa_lookup.json | New citation-key → APA reference mapping used during glossary generation. |
| content/glossary/_create_glossaries.py | New glossary generation pipeline that reads a sheet export and formats references using the APA lookup. |
| bibtex_to_apa/package.json | Adds dependencies for converting BibTeX to APA via citation-js. |
| bibtex_to_apa/package-lock.json | Lockfile for the bibtex→APA conversion tool dependencies. |
| bibtex_to_apa/bibtex_to_apa.js | Node script to fetch BibTeX and emit apa_lookup.json. |
| .github/workflows/data-processing.yml | Installs Node deps and runs the bibtex→APA generation step in CI. |
Files not reviewed (1)
- bibtex_to_apa/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ect/forrtproject.github.io into ks-refactor-glossary-generator
✅ Spell Check PassedNo spelling issues found in this PR! 🎉 |
1 similar comment
✅ Spell Check PassedNo spelling issues found in this PR! 🎉 |
✅ Spell Check PassedNo spelling issues found in this PR! 🎉 |
✅ Spell Check PassedNo spelling issues found in this PR! 🎉 |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
✅ Spell Check PassedNo spelling issues found in this PR! 🎉 |
✅ Spell Check PassedNo spelling issues found in this PR! 🎉 |
✅ Spell Check PassedNo spelling issues found in this PR! 🎉 |
|
@copilot the references generated by this PR look like the attached. Can you help figure out what is wrong? |
|
@LukasWallrich I've opened a new pull request, #639, to work on those changes. Once the pull request is ready, I'll request review from you. |
✅ Spell Check PassedNo spelling issues found in this PR! 🎉 |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 8 changed files in this pull request and generated 16 comments.
Files not reviewed (1)
- bibtex_to_apa/package-lock.json: Language not supported
Comments suppressed due to low confidence (1)
.github/workflows/data-processing.yml:205
- The "Run Tenzing script" step appears in the wrong location in the workflow. It's placed after Node.js setup but the comment suggests it should be processing contributor data. The step also has malformed YAML - there's shell code (sed command and echo) directly under the env block instead of being in a separate run block. This will cause the workflow to fail.
- name: Run Tenzing script
continue-on-error: true # Continue even if this step fails
run: python3 scripts/forrt_contribs/tenzing.py
env:
GSHEET_CREDENTIALS: ${{ secrets.GSHEET_CREDENTIALS }}
# Clean up HTML artifacts from index.md if any
sed -i.bak -e '/^```{=html}$/d' -e '/^```$/d' content/contributor-analysis/index.md && rm content/contributor-analysis/index.md.bak
echo "✅ Contributor analysis complete"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
✅ Spell Check PassedNo spelling issues found in this PR! 🎉 |
There was a problem hiding this comment.
LGTM 💯
but I have minor comments
Suggestions :
References to be visually separated for clarity and readability.
Instead of displaying all APA-formatted references in a single comma-separated line, please use line breaks or bullet points to separate each reference. This will make the “References” section much easier to read and more consistent with APA style.
Example formatting:
- Brown, N., Thompson, P., & Leigh, J. S. (2018)...
- Pollet, I. L., & Bond, A. L. (2021)...
- Suber, P. (2004)...
- Pownall, M., Talbot, C. V., ... (2021)...
Or use <ul>/<li> for HTML, or <br> for line breaks.
✅ Spell Check PassedNo spelling issues found in this PR! 🎉 |
@richarddushime I have updated the PR, looks better now, thank you for the suggestion.
|
|
LGTM 🥇 |
✅ Spell Check PassedNo spelling issues found in this PR! 🎉 |
|
It says all comments must be resolved before merging (which I cannot do) |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
✅ Spell Check PassedNo spelling issues found in this PR! 🎉 |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
✅ Spell Check PassedNo spelling issues found in this PR! 🎉 |
LukasWallrich
left a comment
There was a problem hiding this comment.
Looks good - thanks so much @kaysiz!



Description
Adds an APA-reference lookup workflow and updates glossary generation to use it when producing glossary entry files.
Changes:
content/glossary/apa_lookup.jsonas a citation-key → APA-formatted reference lookup.content/glossary/_create_glossaries.pyto pull glossary data from a Google Sheets CSV export and format references via the APA lookup.Node.js utility (bibtex_to_apa/)and CI workflow steps to generate/update the APA lookup during data processing.Expected behavior:
Glossary entries now show APA-formatted references (from the lookup) instead of raw citation keys.
The language switcher on glossary pages should correctly link to the same entry in other available languages.
@kaysiz you can add more informations that I might have missed about this PR
Type of Change
How Has This Been Tested?
Checklist for Content Editors and Non-Developers
Checklist for Developers:
Additional Notes