Remove redundant Ombudsman->Ombuds override from steering-committee generator#825
Merged
Merged
Conversation
The role label lived in the roster Google Sheet, not in code, so a script-side override was the wrong fix — it would have silently diverged from the sheet forever. Updated row 16 (Role/Team/Role Title) in the live "FORRT Steering Committee | Members" sheet directly and removed the now-unnecessary ROLE_LABEL_OVERRIDES workaround, keeping only the genuine duplicate-DOM-id fix in the generator. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
👍 All image files/references (if any) are in webp format, in line with our policy. |
Contributor
✅ Spell Check PassedNo spelling issues found when checking 1 changed file(s)! 🎉 |
Contributor
Author
|
✅ Staging Deployment Status This PR has been successfully deployed to staging as part of an aggregated deployment. Deployed at: 2026-07-02 12:54:12 UTC The staging site shows the combined state of all compatible open PRs. |
richarddushime
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #824. That PR fixed the "Ombuds" role label on the Steering Committee page by adding a
ROLE_LABEL_OVERRIDESworkaround inscripts/generate_sc_profiles.py, which silently rewrote whatever the roster sheet said. That's the wrong layer for a data fix — it would have quietly diverged from the sheet forever.The actual "Ombudsman" text was fixed at the source instead: the Role/Team/Role Title columns for Thomas Rhys Evans's row were corrected directly in the live "FORRT Steering Committee | Members" Google Sheet. This PR removes the now-redundant script-side override, so the generator just reflects whatever the sheet says (which is now the label the site already shows). The genuine code fix from #824 — giving each person-role occurrence in the sheet a unique DOM id, so a person with two roles gets two independently-openable modals — is untouched.
Test plan
hugo --minifybuild succeeds with no errorscodespellclean on the changed file🤖 Generated with Claude Code